Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] turn on blended layer for geojson upload #63200

Merged
merged 2 commits into from
Apr 13, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Apr 9, 2020

fixes #40090

This PR updates geo_json upload to turn on clusters when uploaded data is geo_point.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kindsun
Copy link
Contributor

kindsun commented Apr 10, 2020

Pretty neat! Seems to work well defaulting to clusters when the file's over 10K. I was able to toggle it back to points as well. The toggling seemed to stop working after this. When I attempted to toggle it to any option after the first couple, it just stopped responding. I tried the same index pattern as a newly added doc layer and didn't have this issue when using the radio select button on the add Layer panel, but then did have the same issue using the radio toggle on the styling panel.

To replicate:

  1. Index the attached file (unzipped) via GeoJSON Upload
  2. Following successful index & add, toggle between different scaling options (this didn't work for me) via the styling panel
  3. Save & close
  4. Add the newly created index pattern as a Doc layer
  5. Toggle between Scaling options on Add layer panel (this should work fine) then add
  6. Toggle between different Scaling options on the styling panel (this didn't work for me)

This seems likely to be a separate issue since it appears specific to styling panel scaling handling. Can you confirm?

tanker_traffic_pnw.json.gz

@nreese
Copy link
Contributor Author

nreese commented Apr 12, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Apr 13, 2020

The toggling seemed to stop working after this. When I attempted to toggle it to any option after the first couple, it just stopped responding. I tried the same index pattern as a newly added doc layer and didn't have this issue when using the radio select button on the add Layer panel, but then did have the same issue using the radio toggle on the styling panel.

Thanks for pointing out the problem with changing Scaling and data not re-fetching. I have opened #63326 to address that issue.

Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for connecting GeoJSON Upload, it's a nice improvement. lgtm!

  • code review
  • tested locally in chrome

@nreese nreese merged commit 69b436e into elastic:master Apr 13, 2020
nreese added a commit to nreese/kibana that referenced this pull request Apr 13, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nreese added a commit that referenced this pull request Apr 13, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] use grid-agg layer as default layer when uploading large geojson point files
4 participants