[NP] Migrate Tagcloud to NP #63445
Merged
[NP] Migrate Tagcloud to NP #63445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
DianaDerevyankina
added
Feature:NP Migration
release_note:skip
DianaDerevyankina
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
69 tasks
maryia-lapata
approved these changes
Apr 21, 2020
| @@ -20,7 +20,7 @@ | |||
| import { createTagCloudFn } from './tag_cloud_fn'; | |||
|
|
|||
| // eslint-disable-next-line | |||
There was a problem hiding this comment.
We don't need to disable eslint here.
# Conflicts: # .i18nrc.json
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
Apr 22, 2020
DianaDerevyankina
added a commit
to DianaDerevyankina/kibana
that referenced
this pull request
Apr 23, 2020
* [NP] Migrate Tagcloud to NP * Fixed eslint issue * Added styles import and disabled eslint in some lines with paths * Added a simple server part and moved tests * Imported setFormatService to fix initialization * Fixed import of setFormatService * Removed unnecessary eslint disable comment
DianaDerevyankina
added a commit
that referenced
this pull request
Apr 23, 2020
* [NP] Migrate Tagcloud to NP * Fixed eslint issue * Added styles import and disabled eslint in some lines with paths * Added a simple server part and moved tests * Imported setFormatService to fix initialization * Fixed import of setFormatService * Removed unnecessary eslint disable comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #60097.
Checklist
Delete any items that are not applicable to this PR.
For maintainers