Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [NP] Visualize (#62294) #63822

Closed
wants to merge 9,900 commits into from
Closed

Conversation

sulemanof
Copy link
Contributor

Backports the following commits to 7.x:

YulNaumenko and others added 30 commits April 7, 2020 10:56
…ok (elastic#62724)

* Improve UX for index document code editor to have similar UX as webhook's

* Fixed jest tests

* Fixed codestyle issue
…e 0 or -1 (elastic#62777)

* changing duration min value for span_frames_min_duration

* adding min property to number field
* Refactor of mocks into own dir ++ added `createAppContextTestRender`
* new AppRootProvider component
* Refactor application `index.tsx` to use `AppRootProvider`
* Add `generatePolicyDatasource()` to EndpointDocGenerator
* Test for policy details
* chore(NA): remove server imports from canvas src plugin

* chore(NA): correctly import types for demodata
…me range query

## Summary

* Fixes the Type Script types so we don't have to use non-null-assertions
* Adds null checks where needed
* Changes the time range query to have a format of epoch to avoid mapping issues

### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
…ach collection (elastic#62665)

* [Telemetry] Add posibility of regitering exclusive collectors for collections

* [Telemetry] Filter unwanted fields from the kibana.os telemetry payload

* Filter the collectors properly in bulkFetch

* Move "kibana" usage collector from Monitoring to OSS Telemetry

* Remove exclusivity of the "kibana_settings" collector

* Unify "kibana_stats" collector from Monitoring and Legacy

* Remove unused legacy constants

* Proper type for UsageCollectionSetup in monitoring

* Missed one undo

* Add unit tests to the migrated collectors

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Move the default_editor to NP

* Fix paths

* Import styles through the visualize

* Other fixes

* Fix ip_ranges exhaustive-deps array

* Fix filters and extend bounds

* Other fixes

* Fix date_ranges tests

* Use useMount on first render

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* documenting sub-feature privileges

* Apply suggestions from code review

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* address PR feedback

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…2752)

* [ML] Adding configurable file size to file data visualizer

* updating translated strings
…astic#61876)

* Fix Canvas storybook webpack config

* Temporarily disable workpad export example

* Mock out lib/notify and download_workpad

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…tic#62276)

* Updates general remote config descriptions

I removed `log_level` from here because it seems it doesn't fit at least the Java, Go and Node agents - see elastic#61821, and it is already deactivated for most others (this doesn't have to be included in this PR though).

* Update general_settings.ts

* Restore log_level definition

* Remove extra spaces

Co-authored-by: Nathan L Smith <smith@nlsmith.com>
…stic#62320)

Summary
- elastic#60022
- Follow up on elastic#60171
- Modifies boolean filters to enum of "included" and "excluded"
- Adds operator types of enum "match", "match_all", "list", and "exists"
- Adds values properties to include those for "list"
- DOES NOT FILTER ON THE VALUES JUST YET (That will be a follow on PR)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…elastic#62876)

[Endpoint] EMT-146: add host status info to the metadata API response
* [Reporting] Fix report table pagination

* update snapshot

* nice little comment
elastic#62382)

* Implemented actions server API for supporting preconfigured connectors defined in kibana.yaml

* Fixed type check

* Fixed due to comments and extended functional tests

* Fixed tests and renamed connectors

* fixed jest tests

* Fixed type checks

* Fixed failing alert save

* Fixed alert client tests

* fixed type checks

* Fixed language check error

* Fixed jest tests

* Added missing comments and docs

* fixed due to comments

* Fixed json config for preconfigured

* fixed type check, reverted config

* config experiment with json stringify

* revert experiment

* Removed the spaces from connector names in config
* support multiple reserved feature privileges

* update reserved privilege ids

* additional testing

* Add ml_user and ml_admin reserved privileges

* prrevent reserved privilege ids from sttarting with 'reserved_'

* address pr feedback: dedicated reserved privilege type

* re-enable ML test suites

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…ted excluded field (elastic#62712)

* exclude keyword and text types of field selected for exclusion

* only show keyword type fields of accepted fields for depVar

* make excludes field logic generic

* fix regex to ensure escaped dot. reset regex and mainfield

* ensure cloned jobs get correct excluded fields

* add clarifying comments
…ic#62461)

* [Maps] Show create filter button top-term tooltip property

* add missing imports

* update import for NP migration

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp and others added 20 commits April 16, 2020 19:28
* [Timeseries] remove unused configuration properties

* Fix PR comments

* update id of vis_type_timeseries plugin

* metrics -> vis_type_timeseries

* fix wrong plugin id

* update requiredPliugins for infra/kibana.json

* change id

* update plugin id in infra folder

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* run endpoint tests with coverage

* add more configs

* add plugin_functional config
elastic#63650)

* add feature_importance column correctly

* wip: switch regression table to datagrid

* add search bar to regression view

* ensure feature importance fields show up correctly

* wip: filter by training/testing

* remove separate testing/training filter

* make error more clear

* handle lucene queries

* remove unnecessary comment

* ensure boolean shows up correctly.no sorting by feature importance

* remove unused translations
Remove `namespaceAgnostic` field that was deprecated in elastic#54605,
use `namespaceType` instead.
* update settings

* added cert form

* update settings

* update types

* update test

* updated tests

* updated snapshots
* Added link to Policy status that updates URL and show details panel
* Custom Styled Flyout Panel sub-header component to display sub-headers
* Move Middleware spy utils under `store/` for re-use
* Changed `appStoreFactory()` to accept optional `additionalMiddleware` prop
* `waitForAction` middleware test utility now return Action on Promise resolve
* Updated PageView component to remove bottom margin
…3016)

* Endpoint successfully depending on ingest manager to initialize

* Moving the endpoint functional tests to their own directory to avoid enabling ingest in the base tests

* Removing page objects and other endpoint fields from base functional

* Updating code owners with new functional location

* Adding index pattern functionality

* Missed a file

* Pointing resolver tests at endpoint functional tests

* Pointing space tests at the endpoint functional directory

* Adding ingest service to do setup and tests for 500s

* Correcting services path

* Adding jest test names

* Updating es archives with the correct mapping and index names

* Fixing import error

* Adding resolver tests to code owners

* enabling epm flag for functional tests

* adding correct tag to test

* Removing the version information and unneeded xsrf

* Addressing endpoint index pattern feedback

* Removing unused import

* Renaming index pattern to es index pattern

* Fixing missed index pattern calls

* Removing unused import

* Fixing type error

* Moving es_index_pattern outside of installed and fixing function name

* Keeping the event index the same for now

* Wrapping index pattern await in try catch

* Address PR feedback, adding comments
Adds support for adding an external vector tile service to Maps. This is experimental functionality. To enable, add `xpack.maps.enableVectorTiles: true` to the `kibana.yml`configuration file.
* [DOCS] Updates remote cluster and ccr docs

* [DOCS] Adds section on managing clusters and follower indices

* [DOCS] Incorporates review comments
Add docs for 7.7 features:

- Alerting
- Duration anomalies
- Settings

Point security docs to heartbeat.
* feat: 🎸 add createStartServicesGetter() to /public  kibana_util

* test: 💍 add createStartServicesGetter() tests
* Fixed server response errors

* Fixed async error

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [Maps] fix term join agg key collision

* fix tslint and jest errors

* fix join functional test

* revert LayerDescriptor union and cast to VectorLayerDescriptor instead

* move getJoinKey out of constants and into its own file

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…eld, Copy to Clipboard, Draggable chart legends (elastic#61207)

## [SIEM] Threat hunting enhancements: Filter for/out value, Show top field, Copy to Clipboard, Draggable chart legends

Enhancements to the threat hunting experience

![show-top-field](https://user-images.githubusercontent.com/4459398/79180753-f9bb7f80-7dc7-11ea-9ae2-d4e4fc79208c.gif)

### New draggable context menu

A new context menu with the following items has been added to all draggables:

- Filter for value
- Filter out value
- Show top _field name_
- Copy to Clipboard

as shown in the following animated gif:

![new-context-menu](https://user-images.githubusercontent.com/4459398/79173935-4dbd6880-7db6-11ea-9253-7746481e1b17.gif)

### Filter for value

The _Filter for value_ context menu action adds the draggable to the global filter bar, which is applicable to all pages in the SIEM app, per the following animated gif:

![filter-in-value](https://user-images.githubusercontent.com/4459398/79176624-f91deb80-7dbd-11ea-9b01-799145d776c8.gif)

### Filter out value

The _Filter out value_ context menu action adds the draggable to the global filter bar as a _negated_ (`NOT`) filter, per the following animated gif:

![filter-out-value](https://user-images.githubusercontent.com/4459398/79178474-9f6bf000-7dc2-11ea-9423-512ad7f89a18.gif)

### Show top _field_

The _Show top field_ context menu action displays an interactive Top 10 histogram, per the following animated gif: 

![show-top-field](https://user-images.githubusercontent.com/4459398/79180753-f9bb7f80-7dc7-11ea-9ae2-d4e4fc79208c.gif)

- The contents of the histogram are filtered by the global KQL bar / filters and current date range
- Brushing over the bars in the histogram updates the global date range / picker
- Select _Events_ or _Signals_
- The _Show top field_ action is also available in the Fields Browser, per the following animated gif:

![in-fields-browser](https://user-images.githubusercontent.com/4459398/79179548-1a360a80-7dc5-11ea-9ad7-cdd7fef0cc64.gif)

### Copy to Clipboard

The _Copy to clipboard_ context menu action copies the draggable field and value to the clipboard in KQL format (e.g. `process.name: "nice"`).

Per the following animated gifs, it's now possible to copy _any_ draggable to the clipboard, and paste it in KQL format, which addresses [this feature request from a user](elastic#59472):

![copy-to-clipboard](https://user-images.githubusercontent.com/4459398/79178893-a7785f80-7dc3-11ea-868a-5d7bc2824912.gif)

![pasted-value](https://user-images.githubusercontent.com/4459398/79179126-2c637900-7dc4-11ea-92a7-86c7d6377688.gif)

### Draggable chart legends

You may now pivot from chart legends by dragging and dropping them to a timeline, or by selecting the Filter for / out context menu action, per the following animated gif:

![draggable-legend](https://user-images.githubusercontent.com/4459398/79179769-9deff700-7dc5-11ea-9153-b472914f2dfe.gif)

#### Desk testing

Desk tested in:

- Chrome `81.0.4044.92`
- Firefox `75.0`
- Safari `13.1`
…ate_index_pattern_wizard) (elastic#63111)

* Migrated create_index_pattern_wizard and its tests to typescript

* Fixed types

* Fixed some comments

* Fixed comments

* Fixed types

* Fixed types

* Fixed snapshot

* Removed indexPatternCreationType from state.

* Fixed comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens and others added 4 commits April 17, 2020 10:18
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* add warnings for legacy 3rd party plugins

* use published doc page for 8.0 breaking changes

* update message to remove fixed 8.0 version reference

* fix generated doc
@sulemanof sulemanof force-pushed the backport/7.x/pr-62294 branch 2 times, most recently from cd97924 to 90f5ce0 Compare April 17, 2020 10:17
@sulemanof sulemanof closed this Apr 17, 2020
@sulemanof sulemanof deleted the backport/7.x/pr-62294 branch April 17, 2020 10:18
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.