Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 flaky retries to ES snapshot jobs #64553

Merged

Conversation

brianseeders
Copy link
Contributor

The ES snapshot verification jobs currently don't do retries at all for flaky failures... This enables retries with an allowance of two failures (two separate ciGroups can each fail once, a ciGroup that fails twice is still a full failure).

Also, adding this directory to the CI skips because it is currently pointless to run PR CI for it. It will still run on this PR because I changed vars/.

@brianseeders brianseeders added v6.8.9 v7.6.3 v7.7.0 v7.8.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Apr 27, 2020
@brianseeders brianseeders requested a review from a team April 28, 2020 14:05
@brianseeders brianseeders added Feature:CI Continuous integration Team:Operations Team label for Operations Team labels Apr 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@brianseeders brianseeders marked this pull request as ready for review April 28, 2020 14:05
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianseeders
Copy link
Contributor Author

@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented Apr 30, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented Apr 30, 2020

Skipped a flaky test and notified the APM folks about the other one, it hasn't failed on a tracked branch yet but this is the third failure across three different PRs in the last three days...

@spalger
Copy link
Contributor

spalger commented Apr 30, 2020

@elasticmachine merge upstream

@brianseeders
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@brianseeders brianseeders merged commit fb30a82 into elastic:master May 4, 2020
@brianseeders brianseeders deleted the es-snapshots-flaky-retries branch May 4, 2020 18:09
brianseeders added a commit to brianseeders/kibana that referenced this pull request May 4, 2020
brianseeders added a commit to brianseeders/kibana that referenced this pull request May 4, 2020
brianseeders added a commit to brianseeders/kibana that referenced this pull request May 4, 2020
brianseeders added a commit to brianseeders/kibana that referenced this pull request May 4, 2020
# Conflicts:
#	.ci/es-snapshots/Jenkinsfile_verify_es
#	vars/prChanges.groovy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v6.8.9 v7.6.3 v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants