-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change createIndexPattern to do what it takes to make the indexPatternName* #64646
Conversation
db8acb4
to
bbba03f
Compare
I have fixes for 2 failures in previous run; I don't have a fix for this one in
|
There was one unrelated test failure. I'll run another pass. |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I replied about possibility to use DELETE key.
Tested on MacOS 10.14.6 in both FF and Chrome
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested locally.
Summary
I updated this PR so that we always pass the exact desired index pattern name in
settings_page.createIndexPattern()
. Within that method, there are 3 cases;logstash-*
and the method enterslogstash-
and we get the correctlogstash-*
because the UI appends a trailing*
shakespeare
and we getshakespeare
(we remove the trailing*
that the UI adds)*
.*
like a wildcarded cross cluster search index pattern*:makelogs-*
.*
which would need to be removed, but it doesn't. So case Change of links to styles and js #2 above handles that by only removing the trailing char if the length of the index pattern in the field is greater than the length of the indexPatternName passed in.A final check (which was already there) confirms that the final value matches what was passed in.
Checklist
Delete any items that are not applicable to this PR.
For maintainers