[APM] Fix duplicate index patterns #64883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +14,9 @@ import { | |||
| TutorialsCategory | |||
| } from '../../../../../src/plugins/home/server'; | |||
|
|
|||
| // duplicated in x-pack/plugins/apm/common/index_pattern_constants.ts | |||
| const APM_STATIC_INDEX_PATTERN_ID = 'apm_static_index_pattern_id'; | |||
There was a problem hiding this comment.
why haven't you imported the one in x-pack/plugins/apm/common/index_pattern_constants.ts?
There was a problem hiding this comment.
Good point 👍
(I was still in the old mindset that this code lived outside the APM app)
An index pattern with the id “apm_static_index_pattern_id” is automatically created when opening the APM app. It is also possible to manually create the index pattern by clicking “Load Kibana Objects” in the Getting Started Guide, however this will create an index pattern with a different id (“apm-*). This fixes it by making sure the index pattern id is always “apm_static_index_pattern_id”.
sorenlouv
force-pushed
the
fix-duplicate-index-patterns
branch
from
289d1b6
to
7002fa8
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
May 4, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 4, 2020
…ana into alerting/np-tests-migration * 'alerting/np-tests-migration' of github.com:gmmorris/kibana: [APM] Agent remote config: validation for Java agent configs (elastic#63956) [APM] Fix duplicate index patterns (elastic#64883) Drilldowns (elastic#61219) [Alerting] fix labels and links in PagerDuty action ui and docs (elastic#64032) [Event Log] Ensure sorting tests are less flaky (elastic#64781) update endpoint to restrict removing with datasources (elastic#64978) [Logs UI] [Alerting] Alerts management page enhancements (elastic#64654) Adjust kibana app owning files (elastic#65064) Migrate tutorial resources (elastic#64298) [Logs UI] Tweak copy in log alerts dialog (elastic#64645) [Logs UI] [Alerting] Documentation (elastic#64886) [Logs UI] Add dataset filter to ML module setup screen (elastic#64470) [TSVB] Fixing memory leak (elastic#64918) Bump backport to 5.4.1 (elastic#65041)
sorenlouv
added a commit
that referenced
this pull request
May 4, 2020
|
Tested:
|
cauemarcondes
added
the
apm:test-plan-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61378
Closes #64765
An index pattern with the id “apm_static_index_pattern_id” is automatically created when opening the APM app. It is also possible to manually create the index pattern by clicking “Load Kibana Objects” in the Getting Started Guide, however this will create an index pattern with a different id (“apm-*).
This fixes it by making sure the index pattern id is always “apm_static_index_pattern_id”.