[chore] Improve request cancelation handling in vis embeddable #65057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Dosant
added
release_note:skip
💚 Build SucceededTo update your PR or re-run it, just comment with: |
ppisljar
reviewed
May 5, 2020
| @@ -331,13 +331,14 @@ export class VisualizeEmbeddable extends Embeddable<VisualizeInput, VisualizeOut | |||
| this.abortController.abort(); | |||
| } | |||
| this.abortController = new AbortController(); | |||
| const abortController = this.abortController; | |||
There was a problem hiding this comment.
why creating local variable ? if we have it lets use it everywhere, but without it this can be a one line PR.
There was a problem hiding this comment.
local variable here is needed as a reference to previous abortController instance.
when await buildPipeline is finished, in case it was aborted, this.abortController would be a reference from next request
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 6, 2020
* master: (72 commits) add tsvb tests to Firefox suite (elastic#65425) Fix flaky ServerMetricsCollector integration test (elastic#65420) [APM] Custom links section inside the Actions menu is showing outside of the menu (elastic#65428) [ML] Adds docs_per_second to transform edit form. (elastic#65365) update apm index pattern (elastic#65424) add direct build command (elastic#65431) [ML] Adding daily_model_snapshot_retention_after_days to types and schemas (elastic#65417) [chore] Improve request cancelation handling in vis embeddable (elastic#65057) [Alerting] migrates acceptance and functional test fixtures to KP (elastic#64888) [ML] Fixes reordering in view by selection when overall cell selected (elastic#65290) Additional branding updates (elastic#64712) Remove redundant formatting of percentage column (elastic#64948) [SIEM][CASE] Configuration pages UI redesign (elastic#65355) New nav (elastic#64018) [Ingest pipelines] Address copy feedback (elastic#65175) bug fixing (elastic#65387) skip whole suite blocking snapshots (elastic#65377) add related event generation to ancestor nodes (fixes a bug) (elastic#64950) [Canvas] move files from legacy/plugins to plugins (elastic#65283) [SIEM] template timeline UI (elastic#64439) ...
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
May 7, 2020
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
May 7, 2020
Dosant
added a commit
that referenced
this pull request
May 7, 2020
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
backport missing
Dosant
added a commit
that referenced
this pull request
May 8, 2020
… (#65636) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on: #61279
This fixes an edge case of cancelation handling if cancelation is happed inside
buildPipelinefunction. e.g. when calculating interval for a histogram.For example,
currently, when calculating the interval for histogram and cancelation has happened, the error is swallowed, and we continue with expression execution for that request. Even though its result is no longer needed and we can reduce the amount of work and save some bandwidth.
(sorry, skipping test, as no existing suite for
visualise_embeddableand no way to nicely cover it in functional suite)Checklist
Delete any items that are not applicable to this PR.
For maintainers