-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @elastic/safer-lodash-set as an alternative to lodash.set #67452
Merged
Merged
Changes from 54 commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
05d9664
Initial inline of @elastic/safer-lodash-set
watson fafb173
Comply with Kibana monorepo rules andi styling
watson 8358e2b
Refactor all use of lodash.set to @elastic/safer-lodash-set
watson f4f7eeb
Add lodash/fp to ESLint blacklist
watson 4d6d865
Remove standardjs badge from README.md
watson d41353c
Rename @elastic/safer-lodash-set to @kbn/safer-lodash-set
watson 3619c8e
For now we don't want to publish this module
watson 49d8875
Merge branch 'master' into safer-lodash-set
watson e68344a
Remove duplicate entry in x-pack/package.json
watson 8dd6a76
Merge branch 'master' into safer-lodash-set
watson 8e54d46
Rename @kbn namespace back to @elastic
watson 48ec297
Add TypeScript tests
watson 3415afd
Merge branch 'master' into safer-lodash-set
watson c1bc23e
Fix new wrong uses of Lodash from master
watson 5eb4809
Update licenses
watson eddf9ff
Expose TypeScript types in package.json
watson 2e1b518
Merge branch 'master' into safer-lodash-set
watson a55d85c
Add license header to script files
watson c12b6bd
Run package tests as part of CI
watson 899bea0
Merge branch 'master' into safer-lodash-set
watson 17719ff
Ups
watson f577950
Merge branch 'master' into safer-lodash-set
watson 20d7b10
Allow ESLint to test the lodash folder
watson 524bf02
Re-adding package to x-pack package.json
watson f2929cb
ups
watson 2d0eefb
Merge branch 'master' into safer-lodash-set
watson 3d21a0d
Remove unchanged lodash files and rely on peerDependency
watson b403435
Add support for lodash/fp
watson e3c12d5
Merge branch 'master' into safer-lodash-set
watson dd254fb
Use @elastic/safer-lodash-set/fp version instead of lodash/fp
watson 5375150
Apply suggestions from code review
watson 7f93093
Merge branch 'master' into safer-lodash-set
watson 88d14ea
Fix typos
watson 4cc8d30
Use bash instead of sh for scripts
watson c85b8f7
Actually run the package tests
watson 664e8b2
Ensure linebreaks are rendered correctly
watson 86c15a2
Throw if prototype is set on arrow-functions
watson 2af8ae0
Use lodash.isFunction instead of typeof
watson 2ac1333
Fix typo in LICENSE
watson 7b1c024
Fix typo in comment
watson cf11b62
Fix .npmignore
watson e0d54fa
Add tsconfig.json
watson 2621244
Use tape instead of assert
watson b942bae
Fix tsd issue related to new tsconfig.json file
watson 747c69e
Remove private field from package.json
watson adbaee6
forgot with tape
watson 2f31347
Bump tsd
watson c3b4351
Fix bug with fp api
watson cea10a8
Add fp TypeScript types
watson 54239dd
Update saved state
watson ccf2b4d
Fix README.md to reflect reality
watson 6d4da53
Extend tsconfig.json from root
watson dd35300
Merge branch 'master' into safer-lodash-set
watson 34316df
Merge branch 'master' into safer-lodash-set
watson a33c7ed
Whitelist files for casing
watson 93ff996
Merge branch 'master' into safer-lodash-set
elasticmachine 7dd9e3e
Merge branch 'master' into safer-lodash-set
elasticmachine fb7c63d
Merge branch 'master' into pr-67452-safer
azasypkin 41c6acf
Disable ESLint `var` warning to be closer to the lodash source code.
azasypkin daf8eb0
Merge branch 'master' into pr-67452-safer
azasypkin 9b99a23
Merge branch 'master' into pr-67452-safer
azasypkin 415fdd2
Merge branch 'master' into safer-lodash-set
elasticmachine 1b4d708
Update yarn.lock.
azasypkin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
.tmp | ||
node_modules |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
tsconfig.json | ||
scripts | ||
test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
The MIT License (MIT) | ||
|
||
Copyright (c) Elasticsearch BV | ||
Copyright (c) Brian Zengel <https://github.com/bczengel>, Ilya Mochalov <https://github.com/chrootsu> | ||
Copyright (c) JS Foundation and other contributors <https://js.foundation/> | ||
|
||
Lodash is based on Underscore.js, copyright Jeremy Ashkenas, | ||
DocumentCloud and Investigative Reporters & Editors <http://underscorejs.org/> | ||
|
||
This software consists of voluntary contributions made by many | ||
individuals. For exact contribution history, see the revision history | ||
available at the following locations: | ||
- https://github.com/lodash/lodash | ||
- https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/lodash | ||
- https://github.com/elastic/kibana/tree/master/packages/elastic-safer-lodash-set | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining | ||
a copy of this software and associated documentation files (the | ||
"Software"), to deal in the Software without restriction, including | ||
without limitation the rights to use, copy, modify, merge, publish, | ||
distribute, sublicense, and/or sell copies of the Software, and to | ||
permit persons to whom the Software is furnished to do so, subject to | ||
the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be | ||
included in all copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, | ||
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF | ||
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND | ||
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE | ||
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION | ||
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION | ||
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: are we going to keep
0.0.0
or you're planning to change it to something else before merge?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't planning to. The
package.json
version number is really only useful for things you download from npm. So me bumping it doesn't really change anything. That being said, I am planning to also release this to npm once merged. When I do that I'll bump to version1.0.0
. I could of course also do that just before the merge and then bump this reference as well... now that I think of it, I might actually do that :)