Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the licensed feature usage API response format #67712

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Updating the licensed feature usage API response format #67712

merged 2 commits into from
Jun 1, 2020

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented May 28, 2020

FeatureUsageServiceSetup::register has been changed from register(featureName: string): void; to register(featureName: string, licenseType: LicenseType): void; so we can also return the license level.

Currently, this is using the featureName as a unique identifier, but it's also supposed to be human-readable. This is somewhat awkward, but it felt equally awkward to introduce a name in addition to an identifier, when both are intended to be unique... Differing opinions or suggestions are welcome!

Resolves #67682

@kobelb kobelb added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels May 28, 2020
@kobelb kobelb requested a review from a team as a code owner May 28, 2020 22:21
@kobelb
Copy link
Contributor Author

kobelb commented Jun 1, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

joshdover
joshdover approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. I'm assuming at this point, we still don't have any consumers of this API within Kibana?

@kobelb
Copy link
Contributor Author

kobelb commented Jun 1, 2020

Not yet, #67526 would be the first

@kobelb kobelb merged commit ce47ef5 into elastic:master Jun 1, 2020
@kobelb kobelb deleted the feature-usage-response branch June 1, 2020 17:09
This was referenced Jun 1, 2020
Merged
Merged
Closed
Closed
Closed
Closed
legrego added a commit to legrego/kibana that referenced this pull request Jun 1, 2020
@legrego
Use updated feature usage API changed by elastic#67712
f88753e
kobelb added a commit that referenced this pull request Jun 1, 2020
@kobelb @elasticmachine
Updating the licensed feature usage API response format (#67712) (#67880
3e2a52a 
)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdover joshdover joshdover approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update licensed feature usage API response format
4 participants
@kobelb @kibanamachine @joshdover @elasticmachine