Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APM Storybook fixes #68671

Merged
merged 1 commit into from
Jun 9, 2020
Merged

APM Storybook fixes #68671

merged 1 commit into from
Jun 9, 2020

Commits on Jun 9, 2020

  1. APM Storybook fixes 

    * Resolve core legacy assets in @kbn/storybook webpack configuration
* Ignore stories in Jest coverage
* Combine effects in Cytoscape component so handlers are always added before events are triggered
* Add mock context to ErrorRateAlertTrigger stories
* Disable TransactionDurationAlertTrigger stories

Changing the Cytoscape effect behavior is necessary because the layout was not being triggered when the final set of elements is provided as props to the component. When this is used in Kibana we're always starting with empty elements and fetching them, but in the Storybook we're starting out with the full elements.
    @smith
    smith committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    603fb09 View commit details
    Browse the repository at this point in the history