[Lens] Last used Index pattern is saved to and retrieved from local storage #69511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
Feature:Lens
release_note:enhancement
Team:Visualizations
mbondyra
changed the title
mbondyra
force-pushed
the
index-pattern-saved
branch
2 times, most recently
from
ce8fcd0
to
d8ae93a
Compare
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
approved these changes
Jun 25, 2020
| @@ -287,10 +300,51 @@ describe('loader', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should load a default state when lastUsedIndexPatternId is not found in indexPatternRefs', async () => { | |||
There was a problem hiding this comment.
Will it also write back to localStorage overwriting the missing index pattern?
There was a problem hiding this comment.
Good idea! I'll add it.
There was a problem hiding this comment.
Actually, that made me think
- (scenario you mentioned) lastUsedIndexPatternId is not found in kibana - we write back to localStorage overwriting the missing index pattern
- (second scenario) we open saved visualization - should we also write back to localStorage? I think so 🤔 -for now we only do it on index pattern change
mbondyra
force-pushed
the
index-pattern-saved
branch
from
28545f0
to
3b71699
Compare
flash1293
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
Tested and LGTM once green - I like the current behavior because If I'm not mistaken it follows this logic:
When opening Lens, show the index pattern which was visible the last time Lens was used, except if it doesn't make sense for the opened visualization.
Looks just right to me, this is what I would expect.
Edit: Just thought about one case where this rule is broken: Create a Lens vis with a layer using pattern "a" and a layer using pattern "b". Create a new Lens vis with "b" visible. Then exit and open the first saved Lens vis again - "a" will be visible initially because it's the first one in the list of the saved object, and the "last used" logic only kicks in if there is no state. I don't think we have to consider this special case, just wanted to mention it. Still LGTM :)
💚 Build SucceededBuild metricspage load asset sizebeta
History
To update your PR or re-run it, just comment with: |
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Jun 26, 2020
mbondyra
added a commit
that referenced
this pull request
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When opening the saved object, the first index pattern from the is the active one. It is set as the
indexPatternIdin local storage.When opening the new lens vis:
2.1. If the last used index pattern is found in local storage and it still exists in kibana, it is set as active.
2.2. If the last used index pattern is found in storage but doesn't exist in kibana, the default one is set as active. The default one is set as the
indexPatternIdin local storage.2.3. If there's no index pattern in storage, the default one is set as active. The default one is set as the
indexPatternIdin local storage.When changing the index pattern in layer or in datasource panel, it is set as the
indexPatternIdin local storage.Fixes #61757
Checklist