Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle change in saml VM name #73808

Merged
merged 6 commits into from
Aug 24, 2020
Merged

Handle change in saml VM name #73808

merged 6 commits into from
Aug 24, 2020

Conversation

marius-dr
Copy link
Member

Changing the env variable used for SAML stack tests, due to change in the VM.
Shouldn't impact anything else. Will need backport until 7.8

@marius-dr marius-dr added test release_note:skip Skip the PR/issue when compiling release notes Feature:Functional Testing labels Jul 30, 2020
@marius-dr marius-dr requested a review from LeeDr July 30, 2020 14:18
@marius-dr
Copy link
Member Author

@elasticmachine merge upstream

@marius-dr marius-dr requested a review from LeeDr August 12, 2020 18:13
Copy link
Contributor

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Just code reviewed

@marius-dr
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@marius-dr marius-dr merged commit 7eb02d1 into master Aug 24, 2020
marius-dr added a commit to marius-dr/kibana that referenced this pull request Aug 24, 2020
* Handle change in saml VM name

* fix lint problem

* Update login_page.ts

* Fix tslint

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
marius-dr added a commit to marius-dr/kibana that referenced this pull request Aug 24, 2020
* Handle change in saml VM name

* fix lint problem

* Update login_page.ts

* Fix tslint

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
marius-dr added a commit that referenced this pull request Aug 25, 2020
* Handle change in saml VM name

* fix lint problem

* Update login_page.ts

* Fix tslint

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
marius-dr added a commit that referenced this pull request Aug 25, 2020
* Handle change in saml VM name

* fix lint problem

* Update login_page.ts

* Fix tslint

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
marius-dr added a commit that referenced this pull request Aug 25, 2020
* Handle change in saml VM name

* fix lint problem

* Update login_page.ts

* Fix tslint

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
parkiino pushed a commit to parkiino/kibana that referenced this pull request Sep 1, 2020
* Handle change in saml VM name

* fix lint problem

* Update login_page.ts

* Fix tslint

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@spalger spalger deleted the marius-dr-patch-saml branch May 8, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants