[ML] DF Analytics: allow failed job to be stopped by force via the UI #74710

alvarezmelissa87 · 2020-08-10T21:13:14Z

Summary

NOTE: Feedback on modal wording is welcome.

This PR replaces the Start action in the analytics list with the Stop action when the job is in a failed state as Start action will fail for a failed job state.

If the job is in a failed state, the user will now see the Stop action which will allow the user to force stop the job. A confirmation modal will appear.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
This was checked for keyboard-only and screenreader accessibility

elasticmachine · 2020-08-10T21:13:17Z

Pinging @elastic/ml-ui (:ml)

walterra

LGTM, just added a small suggestion about the button text in the modal.

walterra · 2020-08-11T07:57:36Z

...data_frame_analytics/pages/analytics_management/components/action_stop/stop_button_modal.tsx

+            confirmButtonText={i18n.translate(
+              'xpack.ml.dataframe.analyticsList.forceStopModalStartButton',
+              {
+                defaultMessage: 'Stop',


Suggest to make the button text Force stop.

sophiec20 · 2020-08-11T08:46:12Z

Can you please loop in @lcawl ? I think it is worth succinctly explaining that a force stop will reset the state of the job and allow you to restart it again, assuming you've rectified the problem.

lcawl

I worked with @gchaps on these suggestions, so if you like them credit goes to the guru!

lcawl · 2020-08-11T23:20:57Z

...data_frame_analytics/pages/analytics_management/components/action_stop/stop_button_modal.tsx

+        <EuiOverlayMask>
+          <EuiConfirmModal
+            title={i18n.translate('xpack.ml.dataframe.analyticsList.forceStopModalTitle', {
+              defaultMessage: 'Force stop {analyticsId}',


In case the job name is long, can we put it in the body of the message instead of the title?

Suggested change

defaultMessage: 'Force stop {analyticsId}',

defaultMessage: 'Force this job to stop?',

lcawl · 2020-08-11T23:21:50Z

...data_frame_analytics/pages/analytics_management/components/action_stop/stop_button_modal.tsx

+            confirmButtonText={i18n.translate(
+              'xpack.ml.dataframe.analyticsList.forceStopModalStartButton',
+              {
+                defaultMessage: 'Stop',


Agree with suggestion from @walterra

Suggested change

defaultMessage: 'Stop',

defaultMessage: 'Force stop',

lcawl · 2020-08-11T23:24:08Z

...data_frame_analytics/pages/analytics_management/components/action_stop/stop_button_modal.tsx

+            <p>
+              <FormattedMessage
+                id="xpack.ml.dataframe.analyticsList.forceStopModalBody"
+                defaultMessage="The analytics job is in the failed state, do you want to force stop {analyticsId}?"


If we want to hint at some of the next steps, I suggest something like this:

Suggested change

defaultMessage="The analytics job is in the failed state, do you want to force stop {analyticsId}?"

defaultMessage="{analyticsId} is in a failed state. You must stop the job and fix the failure."

Thank you, @lcawl! 🙏 😄 All updates in 61308c2

jgowdyelastic

LGTM

kibanamachine · 2020-08-13T18:05:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 61308c2

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
ml	1355	+2	1353

async chunks size

id	value	diff	baseline
ml	8.0MB	+12.6KB	8.0MB

History

💚 Build #67386 succeeded 3ecc90a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…elastic#74710) * allow force stop from ui if job is failed * update wording in confirm modal

…#74710) (#74983) * allow force stop from ui if job is failed * update wording in confirm modal

* master: (23 commits) Adding API test for custom link transaction example (elastic#74238) [Uptime] Singular alert (elastic#74659) Revert "attempt excluding a codeowners directory" (elastic#75023) [Metrics UI] Remove TSVB dependency from Metrics Explorer APIs (elastic#74804) Remove degraded state from ES status service (elastic#75007) [Reporting/Functional] unskip pagination test (elastic#74973) [Resolver] Stale query string values are removed when resolver's component instance ID changes. (elastic#74979) Add public url to Workplace Search plugin (elastic#74991) [Reporting] Update more Server Types for TaskManager (elastic#74915) [I18n] verify select icu-message options are in english (elastic#74963) Make data.search.aggs available on the server. (elastic#74472) [Security Solution][Resolver] Graph Control Tests and Update Simulator Selectors (elastic#74680) attempt excluding a codeowners directory [ML] DF Analytics: allow failed job to be stopped by force via the UI (elastic#74710) Add kibana-core-ui-designers team (elastic#74970) [Metrics UI] Fix inventory footer misalignment (elastic#74707) Remove legacy optimizer (elastic#73154) Update design-specific GH code-owners (elastic#74877) skip test Reporting paginates content elastic#74922 [Metrics UI] Add Jest tests for alert previews (elastic#74890) ...

alvarezmelissa87 added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:Data Frame Analytics ML data frame analytics features v7.10.0 labels Aug 10, 2020

alvarezmelissa87 requested a review from a team as a code owner August 10, 2020 21:13

alvarezmelissa87 self-assigned this Aug 10, 2020

alvarezmelissa87 requested review from walterra, darnautov and jgowdyelastic August 10, 2020 21:13

alvarezmelissa87 mentioned this pull request Aug 10, 2020

[ML] Allow force stop job action on DFA job failure #72661

Closed

walterra approved these changes Aug 11, 2020

View reviewed changes

lcawl reviewed Aug 11, 2020

View reviewed changes

jgowdyelastic approved these changes Aug 12, 2020

View reviewed changes

allow force stop from ui if job is failed

9c1e1fd

alvarezmelissa87 force-pushed the ml-dfanalytics-force-stop-in-edit branch from 3ecc90a to 9c1e1fd Compare August 13, 2020 16:09

update wording in confirm modal

61308c2

alvarezmelissa87 merged commit 479a991 into elastic:master Aug 13, 2020

alvarezmelissa87 mentioned this pull request Aug 13, 2020

[7.x] [ML] DF Analytics: allow failed job to be stopped by force via the UI (#74710) #74983

Merged

alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Aug 13, 2020

[ML] DF Analytics: allow failed job to be stopped by force via the UI (…

ce6a4bf

…elastic#74710) * allow force stop from ui if job is failed * update wording in confirm modal

alvarezmelissa87 deleted the ml-dfanalytics-force-stop-in-edit branch August 13, 2020 18:20

alvarezmelissa87 added a commit that referenced this pull request Aug 13, 2020

[ML] DF Analytics: allow failed job to be stopped by force via the UI (…

86d8d41

…#74710) (#74983) * allow force stop from ui if job is failed * update wording in confirm modal

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] DF Analytics: allow failed job to be stopped by force via the UI #74710

[ML] DF Analytics: allow failed job to be stopped by force via the UI #74710

alvarezmelissa87 commented Aug 10, 2020 •

edited

Loading

elasticmachine commented Aug 10, 2020

walterra left a comment

walterra Aug 11, 2020

sophiec20 commented Aug 11, 2020

lcawl left a comment

lcawl Aug 11, 2020

lcawl Aug 11, 2020

lcawl Aug 11, 2020

alvarezmelissa87 Aug 13, 2020 •

edited

Loading

jgowdyelastic left a comment

kibanamachine commented Aug 13, 2020

	defaultMessage: 'Force stop {analyticsId}',
	defaultMessage: 'Force this job to stop?',

	defaultMessage="The analytics job is in the failed state, do you want to force stop {analyticsId}?"
	defaultMessage="{analyticsId} is in a failed state. You must stop the job and fix the failure."

[ML] DF Analytics: allow failed job to be stopped by force via the UI #74710

[ML] DF Analytics: allow failed job to be stopped by force via the UI #74710

Conversation

alvarezmelissa87 commented Aug 10, 2020 • edited Loading

Summary

Checklist

elasticmachine commented Aug 10, 2020

walterra left a comment

Choose a reason for hiding this comment

walterra Aug 11, 2020

Choose a reason for hiding this comment

sophiec20 commented Aug 11, 2020

lcawl left a comment

Choose a reason for hiding this comment

lcawl Aug 11, 2020

Choose a reason for hiding this comment

lcawl Aug 11, 2020

Choose a reason for hiding this comment

lcawl Aug 11, 2020

Choose a reason for hiding this comment

alvarezmelissa87 Aug 13, 2020 • edited Loading

Choose a reason for hiding this comment

jgowdyelastic left a comment

Choose a reason for hiding this comment

kibanamachine commented Aug 13, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

async chunks size

History

alvarezmelissa87 commented Aug 10, 2020 •

edited

Loading

alvarezmelissa87 Aug 13, 2020 •

edited

Loading