Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Don't retain POST /setup results. fixes #74587 #75372

Merged
merged 23 commits into from
Aug 20, 2020

Commits on Aug 6, 2020

  1. add retries for registry requests.

    works, afaict. no tests. one TS issue.
    John Schulz committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    bf2196d View commit details
    Browse the repository at this point in the history
  2. Fix TS issue. Add link to node-fetch error docs

    John Schulz committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    73a7e04 View commit details
    Browse the repository at this point in the history
  3. Restore some accidentally deleted code.

    John Schulz committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    a565c02 View commit details
    Browse the repository at this point in the history
  4. Add more comments. Remove logging.

    John Schulz committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    877ecd7 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2020

  1. Configuration menu
    Copy the full SHA
    2a2fd17 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2020

  1. Configuration menu
    Copy the full SHA
    bf973b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. Add tests for plugin setup service & handlers

    John Schulz committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    3440dd7 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. Add tests for Registry retry logic

    John Schulz committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    f6a8272 View commit details
    Browse the repository at this point in the history
  2. Extract setup retry logic to separate function/file

    John Schulz committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    44ed63b View commit details
    Browse the repository at this point in the history
  3. Add tests for setup retry logic

    ```
      firstSuccessOrTryAgain
        ✓ reject/throws is called again & its value returned (18ms)
        ✓ the first success value is cached (2ms)
    ```
    John Schulz committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    a077988 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ab56cfa View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. More straightforward(?) tests for setup caching

    John Schulz committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    85cf9b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b7ce43e View commit details
    Browse the repository at this point in the history
  3. Revert cached setup. Still limit 1 call at a time

    Terrible tests. Committing & pushing to see if it fixes failures like https://github.com/elastic/kibana/pull/74507/checks?check_run_id=980178887
    
    https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/67892/execution/node/663/log/
    
    ```
    07:36:56               └-> "before all" hook
    07:36:56               └-> should not allow to enroll an agent with a invalid enrollment
    07:36:56                 └-> "before each" hook: global before each
    07:36:56                 └-> "before each" hook: beforeSetupWithDockerRegistry
    07:36:56                 │ proc [kibana]  error  [11:36:56.369]  Error: Internal Server Error
    07:36:56                 │ proc [kibana]     at HapiResponseAdapter.toError (/dev/shm/workspace/parallel/5/kibana/build/kibana-build-xpack/src/core/server/http/router/response_adapter.js:132:19)
    07:36:56                 │ proc [kibana]     at HapiResponseAdapter.toHapiResponse (/dev/shm/workspace/parallel/5/kibana/build/kibana-build-xpack/src/core/server/http/router/response_adapter.js:86:19)
    07:36:56                 │ proc [kibana]     at HapiResponseAdapter.handle (/dev/shm/workspace/parallel/5/kibana/build/kibana-build-xpack/src/core/server/http/router/response_adapter.js:81:17)
    07:36:56                 │ proc [kibana]     at Router.handle (/dev/shm/workspace/parallel/5/kibana/build/kibana-build-xpack/src/core/server/http/router/router.js:164:34)
    07:36:56                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:68:7)
    07:36:56                 │ proc [kibana]   log   [11:36:56.581] [info][authentication][plugins][security] Authentication attempt failed: [security_exception] missing authentication credentials for REST request [/_security/_authenticate], with { header={ WWW-Authenticate={ 0="ApiKey" & 1="Basic realm=\"security\" charset=\"UTF-8\"" } } }
    07:36:56                 └- ✓ pass  (60ms) "Ingest Manager Endpoints Fleet Endpoints fleet_agents_enroll should not allow to enroll an agent with a invalid enrollment"
    07:36:56               └-> should not allow to enroll an agent with a shared id if it already exists
    07:36:56                 └-> "before each" hook: global before each
    07:36:56                 └-> "before each" hook: beforeSetupWithDockerRegistry
    07:36:56                 └- ✓ pass  (111ms) "Ingest Manager Endpoints Fleet Endpoints fleet_agents_enroll should not allow to enroll an agent with a shared id if it already exists "
    07:36:56               └-> should not allow to enroll an agent with a version > kibana
    07:36:56                 └-> "before each" hook: global before each
    07:36:56                 └-> "before each" hook: beforeSetupWithDockerRegistry
    07:36:56                 └- ✓ pass  (58ms) "Ingest Manager Endpoints Fleet Endpoints fleet_agents_enroll should not allow to enroll an agent with a version > kibana"
    07:36:56               └-> should allow to enroll an agent with a valid enrollment token
    07:36:56                 └-> "before each" hook: global before each
    07:36:56                 └-> "before each" hook: beforeSetupWithDockerRegistry
    07:36:56                 └- ✖ fail: Ingest Manager Endpoints Fleet Endpoints fleet_agents_enroll should allow to enroll an agent with a valid enrollment token
    07:36:56                 │      Error: expected 200 "OK", got 500 "Internal Server Error"
    07:36:56                 │       at Test._assertStatus (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:268:12)
    07:36:56                 │       at Test._assertFunction (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:283:11)
    07:36:56                 │       at Test.assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:173:18)
    07:36:56                 │       at assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:131:12)
    07:36:56                 │       at /dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:128:5
    07:36:56                 │       at Test.Request.callback (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/index.js:718:3)
    07:36:56                 │       at parser (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/index.js:906:18)
    07:36:56                 │       at IncomingMessage.res.on (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/parsers/json.js:19:7)
    07:36:56                 │       at endReadableNT (_stream_readable.js:1145:12)
    07:36:56                 │       at process._tickCallback (internal/process/next_tick.js:63:19)
    07:36:56                 │
    07:36:56                 │
    ```
    John Schulz committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    27a0252 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2020

  1. Configuration menu
    Copy the full SHA
    e220bbd View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2020

  1. Configuration menu
    Copy the full SHA
    409ef85 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2020

  1. New name & tests for one-at-a-time /setup behavior

    `firstPromiseBlocksAndFufills` for "the first promise created blocks others from being created, then fufills all with that first result"
    John Schulz committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    a7d7261 View commit details
    Browse the repository at this point in the history
  2. More (better?) renaming

    John Schulz committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    a6bd2d2 View commit details
    Browse the repository at this point in the history
  3. Fix name in test description

    John Schulz committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    fe66914 View commit details
    Browse the repository at this point in the history
  4. Fix spelling typo.

    John Schulz committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    3a89cde View commit details
    Browse the repository at this point in the history
  5. Remove registry retry code & tests

    John Schulz committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    deafa13 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Use async fn's .catch to avoid unhandled rejection

    Add explicit `isPending` value instead of overloading role of `status`. Could probably do without it, but it makes the intent more clear.
    John Schulz committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    a913911 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into 74587-retry-f…

    …ailed-setup
    John Schulz committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    55d7bba View commit details
    Browse the repository at this point in the history