fix for #7329 -- plugin versions updated

[ppisljar]

fix #7329

i just updated plugin versions in package.json file of each plugin.

i am not sure what @pickypg meant with his comment to issue ...
test just checks for kibana plugin to be present it doesn't check the version number.

anyway this feels a bit counter productive ...

• we will be updating versions of this plugins with each kibana version
• even if plugins wont change their version will be updated

maybe it would be better to update this versions from main package.json at the build time ?

[epixa]

I think we definitely need to make this functionality dynamic in some way rather than hardcoding core plugin versions.

[ppisljar]

i completely agree. suggestions ?

[Bargs]

Perhaps core plugins shouldn't have a version specified in their package.json at all, and it should just default to the version of kibana in the UI

[epixa]

+1

[pickypg]

i am not sure what @pickypg meant with his comment to issue ...

FYI, back when I made the comment, the test was more brittle:

e232e07

It's fine now.

[pickypg]

I wonder if this is too loose? I like what it's enabling, but I wonder if the behavior should be explicit?

Instead of removing version from every built-in plugin, just mark it with "version" : "kibana", or something similar, and use that to inherit Kibana's version. That way it at least implies to plugin authors that they should provide their own version number and not just make version irrelevant for every plugin ("oh, it always matches Kibana", which shouldn't be true for things that are compiled + released at the same time).

[pickypg]

LGTM

[Bargs]

@ppisljar in the future, please try to get 2 official LGTM from Kibana engineers prior to merging a PR.

[ppisljar]

sorry, will do.