Top navigation bar should expand with content. #7850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the breadcrumbs stack vertically the header should expand vertically as well. Otherwise, the breadcrumbs float outside the header. This rearrangement happens when the screen is minimized horizontally, and the breadcrumbs change from horizontal to vertical layout.
thomasneirynck
assigned thomasneirynck, cjcenizal and jbudz and unassigned thomasneirynck
|
LGTM |
|
LGTM! |
|
this also addresses #7810. |
simianhacker
pushed a commit
to simianhacker/kibana
that referenced
this pull request
Aug 23, 2016
simianhacker
pushed a commit
to simianhacker/kibana
that referenced
this pull request
Aug 23, 2016
simianhacker
pushed a commit
to simianhacker/kibana
that referenced
this pull request
Aug 23, 2016
Added percentage option to significant_terms agg Significant terms: add scriptable significance heuristic elastic#7850 Add `format` support for date range filter and queries elastic#7821 Add `min_score` parameter to function score query to only match docs
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Top navigation bar should expand with content. Former-commit-id: ebf196b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #7808.
This change preserves the current behavior: the navigation bar continues to line up with the Kibana-logo, which was the original reason for the
70pxheight.Note that the current highlight-style - which underlines the nav-links - does not look that great when the breadcrumbs stack vertically. This is however a larger styling issues that can be addressed separately.