Trim down test harness #8146
Merged
Trim down test harness #8146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
remove/stackTraceMapper
branch
from
a8c897d
to
e032387
Compare
spalger
force-pushed
the
remove/stackTraceMapper
branch
2 times, most recently
from
c18bc3d
to
6a659af
Compare
spalger
force-pushed
the
remove/stackTraceMapper
branch
from
6a659af
to
53aa6d2
Compare
| }); | ||
| }); | ||
| // Setup auto releasing stubs and spys | ||
| setupAutoRelease(sinon, window.afterEach); |
There was a problem hiding this comment.
I see setupAutoRelease(sinon, window.afterEach); on line 12 and line 16. Is it needed in both places?
| // chrome expects to be loaded first, let it get its way | ||
| import chrome from 'ui/chrome'; | ||
|
|
||
| import Nonsense from 'Nonsense'; |
There was a problem hiding this comment.
I couldn't find any other usages of Nonsense. Think it's safe to remove the dependency from package.json?
|
LGTM after changes above. |
spalger
force-pushed
the
remove/stackTraceMapper
branch
from
53aa6d2
to
ae4dded
Compare
epixa
pushed a commit
that referenced
this pull request
Oct 29, 2016
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Nov 10, 2016
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Backports PR elastic#8146 **Commit 1:** trim down test harness, remove StackTraceMapper * Original sha: ae4dded * Authored by spalger <email@spalger.com> on 2016-09-01T16:11:45Z Former-commit-id: 2991900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on #8150
While investigating potential memory leaks, discovered some unnecessary stuff in the test harness.
ui/stack_trace_mapper, it didn't work anywayNonsense, it also didn't work