Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v30.1.1 #81499

Merged
merged 57 commits into from
Oct 30, 2020
Merged

Upgrade EUI to v30.1.1 #81499

merged 57 commits into from
Oct 30, 2020

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Oct 22, 2020

Summary

eui@29.5.0eui@30.1.1

Notable breaking changes:

All breaks have been accounted for. No action (beyond review) is required

  • Removed EuiToggle and EuiButtonToggle. All current uses have been updated per "Upgrade path" guidelines in Fix EuiButtonGroup a11y and remove EuiToggle/EuiButtonToggle eui#4056.
  • Removed EuiNavDrawer. The component had already been replaced with EuiCollapsibleNav, and all residual code referencing EuiNavDrawer assets has been removed.
  • Removed compressed and displayOnly props from EuiFormRow. All current uses have been updated to use the successor display prop.
  • Removed EuiPopover's withTitle prop. This prop has not provided any benefit for some time and there will be no visual difference with its removal.
  • Refactored EuiButtonGroup for a11y and introduced new required props for selection (idSelected or idToSelectedMap) and screen reader support (legend).

Note that EuiKeyboardAccessible has been deprecated and will be removed in a future major version.


30.1.1

  • Added more exports for EuiInMemoryTable types (#4179)

Bug fixes

  • Removed unnecessary shadow on hover of EuiButtonGroup (#4186)
  • Fixed position of EuiScreenReaderOnly elements within EuiButtonGroup (#4189)

30.1.0

  • Improved EuiButtonGroup focus, hover, selected and disabled states (#4142)
  • Added display prop to EuiToolTip for common display block needs (#4148)
  • Added support for more colors in EuiProgress such as vis0 through vis9, warning, success and custom colors (#4130)
  • Added affordForDisplacement prop to EuiBottomBar (#4156)
  • Added width property to mobileOptions prop of EuiTableRowCell (#4169)

Bug fixes

  • Fixed issue with duplicate checkmarks in EuiComboBox (#4162)
  • Reinstated base element type extensions for EuiStepHorizontal and EuiStepsHorizontal (4166)

30.0.0

  • Deprecated EuiKeyboardAccessible ([4135]Deprecating EuiKeyboardAccessible eui#4135)
  • Refactored EuiStep, EuiHorizontalSteps, and EuiCodeEditor for better accessibility ([4135]Deprecating EuiKeyboardAccessible eui#4135)
  • Added minWidth prop to EuiButton (4056)
  • Added isSelected prop to easily turn EuiButton, EuiButtonEmpty, and EuiButtonIcon into toggle buttons (4056)
  • Updated EuiButtonGroup props and render for better accessibility (4056)
  • Added paddingSize prop to EuiPopoverTitle and EuiPopoverFooter (4133)
  • Added more exports for EuiBasicTable types (#4125)
  • Updated types associated with EuiMarkdownEditor plugin dependencies (4124)
  • Upgraded dependencies related to EuiMarkdownEditor: react-dropzone, rehype-*, remark-*, and unified (#4124)

Bug fixes

  • Fixed focus management bug in EuiSelectable (4152)

Breaking changes

  • Removed EuiToggle and EuiButtonToggle in favor of aria-pressed (4056)
  • Updated legend and idSelected props of EuiButtonGroup to be required (4056)
  • Removed logoAPM in favor of logoObservability (4065)
  • Removed .euiHeaderNotification CSS class (4065)
  • Removed EuiNavDrawer in favor of EuiCollapsibleNav (4065)
  • Removed compressed and displayOnly props from EuiFormRow in favor of the display prop (4065)
  • Removed EuiPopover's withTitle prop (4065)

Theme: Amsterdam

  • Tightened line-height for some EuiTitle sizes (4133)
  • Removed uppercase from EuiPopoverTitle and fixed inherited padding from EuiPopover (4133)
  • Fixed EuiFilterGroup and EuiFilterButton styles (4151)

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Oct 22, 2020
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for monitoring!

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM - left one small a11y I'm not sure about. It's probably nothing, just wanted to make sure it was considered.

Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation changes look good to me

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KibanaApp changes LGTM 🎉

@cchaos cchaos requested a review from a team October 30, 2020 16:21
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thompsongl thompsongl requested review from cnasikas and removed request for chandlerprall October 30, 2020 17:18
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
core 451 448 -3
ingestManager 549 535 -14
kibanaReact 312 309 -3
kibanaUtils 192 189 -3
security 463 460 -3
securitySolution 2067 2064 -3
total -29

@kbn/ui-shared-deps asset size

id before after diff
css 645.3KB 650.1KB +4.8KB
kbn-ui-shared-deps.@elastic.js 2.4MB 2.4MB -6.7KB
kbn-ui-shared-deps.js 4.8MB 4.8MB -3.8KB
total -5.7KB

async chunks size

id before after diff
apm 3.2MB 3.2MB -60.0B
canvas 1.3MB 1.3MB +89.0B
core 258.3KB 255.5KB -2.8KB
crossClusterReplication 357.7KB 357.7KB -30.0B
data 235.1KB 235.0KB -60.0B
enterpriseSearch 638.2KB 638.2KB +21.0B
home 347.5KB 347.6KB +125.0B
indexLifecycleManagement 223.9KB 223.9KB -15.0B
indexManagement 1.5MB 1.5MB -60.0B
indexPatternManagement 604.4KB 604.3KB -15.0B
infra 2.6MB 2.6MB +4.0B
ingestManager 1.2MB 1.2MB -12.2KB
ingestPipelines 795.2KB 795.1KB -71.0B
kibanaReact 352.8KB 350.0KB -2.8KB
kibanaUtils 125.8KB 123.0KB -2.8KB
maps 2.7MB 2.7MB -11.0B
ml 6.6MB 6.6MB -84.0B
monitoring 964.4KB 964.4KB -30.0B
observability 160.8KB 160.8KB +30.0B
painlessLab 37.7KB 37.6KB -15.0B
rollup 268.8KB 268.8KB -15.0B
security 816.3KB 814.1KB -2.2KB
securitySolution 7.8MB 7.8MB -2.1KB
snapshotRestore 583.5KB 583.4KB -30.0B
transform 1.1MB 1.1MB -78.0B
triggersActionsUi 1.5MB 1.5MB -14.0B
uptime 1.1MB 1.1MB +126.0B
visDefaultEditor 430.9KB 431.6KB +714.0B
visTypeTimelion 74.3KB 74.4KB +8.0B
visTypeVislib 700.3KB 702.0KB +1.8KB
watcher 953.4KB 953.4KB -60.0B
total -22.7KB

distributable file count

id before after diff
default 48162 48123 -39
oss 28623 28585 -38

page load bundle size

id before after diff
canvas 918.4KB 919.3KB +910.0B
charts 134.8KB 134.9KB +48.0B
embeddable 219.6KB 219.6KB -15.0B
indexLifecycleManagement 69.4KB 69.4KB -15.0B
kibanaReact 131.4KB 131.5KB +88.0B
painlessLab 26.0KB 24.9KB -1.1KB
share 70.4KB 70.4KB -15.0B
spaces 286.8KB 286.7KB -53.0B
triggersActionsUi 131.8KB 131.7KB -75.0B
uiActions 67.8KB 67.7KB -15.0B
uiActionsEnhanced 304.3KB 304.3KB -15.0B
upgradeAssistant 64.1KB 64.2KB +51.0B
visDefaultEditor 30.9KB 30.9KB +8.0B
visTypeVislib 66.1KB 66.1KB +8.0B
total -202.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security changes LGTM! 👍 Thanks for addressing @cnasikas's comments @thompsongl, appreciate it! 🙂

@thompsongl thompsongl removed the request for review from cnasikas October 30, 2020 22:08
@thompsongl thompsongl merged commit 6fdc7eb into elastic:master Oct 30, 2020
thompsongl added a commit to thompsongl/kibana that referenced this pull request Oct 30, 2020
* eui to v30.0.0

* removed unused RecentLinks component

* update compressed -> display prop

* euiformrow compressed -> display

* euipopover remove withtitle

* euibuttongroup prop updates

* remove euibuttontoggle

* src snapshot updates

* tutorial euibuttongroup update

* x-pack snapshot updates

* euibuttongroup test updates

* TODO

* misc. js file updates

* remove euinavdrawer scss references

* translation removals

* more x-pack snapshot updates

* update data-test-subj lookup

* icons logoAMP -> logoObservability

* cypress selector updates

* update euibuttontoggle onchange, test interaction

* Fix auto-update toggle in Visualize

* some more change -> click test updates

* idtoselectedmap change

* Fix feature table button group

* Remove empty SASS file

* Fix feature table button group II

* Using `compressed` to also dictate dual range row

* Fix a few security labels

* An ML fix

* Apply suggestions from code review

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* remove unused translation

* update view_type_toggle snapshot

* more snapshot updates

* eui to 30.1.0

* undo temp ts-ignore

* more x-pack snapshot updates

* eui to 30.1.1

* update feature privilege text

* Update x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/feature_table/sub_feature_form.tsx

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* reuse i18n token

* Adapt log entry action button to new `minWidth` prop

* clean up label

* Combine auto apply strings into one

* ternary fix

* cases status useCallback

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Co-authored-by: Felix Stürmer <stuermer@weltenwort.de>
thompsongl added a commit that referenced this pull request Oct 31, 2020
* eui to v30.0.0

* removed unused RecentLinks component

* update compressed -> display prop

* euiformrow compressed -> display

* euipopover remove withtitle

* euibuttongroup prop updates

* remove euibuttontoggle

* src snapshot updates

* tutorial euibuttongroup update

* x-pack snapshot updates

* euibuttongroup test updates

* TODO

* misc. js file updates

* remove euinavdrawer scss references

* translation removals

* more x-pack snapshot updates

* update data-test-subj lookup

* icons logoAMP -> logoObservability

* cypress selector updates

* update euibuttontoggle onchange, test interaction

* Fix auto-update toggle in Visualize

* some more change -> click test updates

* idtoselectedmap change

* Fix feature table button group

* Remove empty SASS file

* Fix feature table button group II

* Using `compressed` to also dictate dual range row

* Fix a few security labels

* An ML fix

* Apply suggestions from code review

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* remove unused translation

* update view_type_toggle snapshot

* more snapshot updates

* eui to 30.1.0

* undo temp ts-ignore

* more x-pack snapshot updates

* eui to 30.1.1

* update feature privilege text

* Update x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/feature_table/sub_feature_form.tsx

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* reuse i18n token

* Adapt log entry action button to new `minWidth` prop

* clean up label

* Combine auto apply strings into one

* ternary fix

* cases status useCallback

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Co-authored-by: Felix Stürmer <stuermer@weltenwort.de>

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Co-authored-by: Felix Stürmer <stuermer@weltenwort.de>
@cnasikas
Copy link
Member

@thompsongl Thank you for addressing my comments! I appreciate it too!

gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 2, 2020
* master:
  Add derivative function (elastic#81178)
  [Discover] Deangularize context_app.html, part 3 (elastic#81838)
  [Visualize] Vis listing page breaks on unknown vis type (elastic#82018)
  Rename `batchSize` parameter to `batch_size` to be consisten with the API namings guidelines. (elastic#82123)
  Minor edits in Single Metric Viewer (elastic#82159)
  [Actions] Fix type contract (elastic#82168)
  Upgrade EUI to v30.1.1 (elastic#81499)
  Skip failing ES snapshot test (elastic#82207)
  Skip ES snapshot failing suite (elastic#82206)
  [Alerting UI] Grouped list of alert types using producers in Types filter of Alerts tab (elastic#81876)
  [Maps] convert vector style component to typescript round 1 (elastic#81961)
  Fix link to upgrade assistant (elastic#82138)
  Rename "service overview" to "service inventory" (elastic#81933)
  adjust policy test to drop test for server addresses (elastic#82120)
  Cleanup/codeowners (elastic#82146)
  [DOCS] Updates add data content (elastic#81093)
  [DOCS] Remove index mgmt docs (elastic#82099)
  [Search] fix cancelation related memory leaks (elastic#81996)
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 2, 2020
…e-details-overlay

* 'master' of github.com:elastic/kibana: (72 commits)
  [CCR] Update README.md on how to start 2 clusters for testing (elastic#81487)
  [APM] Scale transaction rate correctly (elastic#82155)
  Upgrade to hapi version 18 (elastic#80468)
  [Uptime] Remove custom handling of license enabling (elastic#82019)
  [Telemetry] Remove `from` and `to` timestamps from usage stats APIs (elastic#81579)
  Enable send to background in Vega (elastic#82229)
  Enable send to background in Timelion (elastic#82232)
  [Actions & Connectors] removes Connector flyouts after usage (elastic#82126)
  Add derivative function (elastic#81178)
  [Discover] Deangularize context_app.html, part 3 (elastic#81838)
  [Visualize] Vis listing page breaks on unknown vis type (elastic#82018)
  Rename `batchSize` parameter to `batch_size` to be consisten with the API namings guidelines. (elastic#82123)
  Minor edits in Single Metric Viewer (elastic#82159)
  [Actions] Fix type contract (elastic#82168)
  Upgrade EUI to v30.1.1 (elastic#81499)
  Skip failing ES snapshot test (elastic#82207)
  Skip ES snapshot failing suite (elastic#82206)
  [Alerting UI] Grouped list of alert types using producers in Types filter of Alerts tab (elastic#81876)
  [Maps] convert vector style component to typescript round 1 (elastic#81961)
  Fix link to upgrade assistant (elastic#82138)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.