Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Use eui component instead of custom color stops #85239

Merged
merged 4 commits into from
Dec 9, 2020

Conversation

flash1293
Copy link
Contributor

This PR removes the custom logic to show the chosen palette in the dimension and switches to the eui component EuiColorPaletteDisplay

Screenshot 2020-12-08 at 10 42 44

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.11.0 labels Dec 8, 2020
@flash1293 flash1293 marked this pull request as ready for review December 8, 2020 12:14
@flash1293 flash1293 requested a review from a team December 8, 2020 12:14
@flash1293 flash1293 requested a review from a team as a code owner December 8, 2020 12:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

))}
</EuiFlexGroup>
<div className="lnsLayerPanel__paletteContainer">
<EuiColorPaletteDisplay size="xs" palette={accessorConfig.palette} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change, @flash1293. Super minor nitpick, but any chance we can do the following to apply two small style overrides to this EuiColorPaletteDisplay (to make it look more at home in the dimension item)?

  1. Apply a className="lnsLayerPanel__palette" to EuiColorPaletteDisplay.
  2. Apply the following styles to this class to adjust the border radius and remove the border:
.lnsLayerPanel__palette {
  border-radius: 0 0 ($euiBorderRadius - 1px) ($euiBorderRadius - 1px);

  &::after {
    border: none;
  }
}

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @flash1293 I wanted to check your PR already with changes @MichaelMarcialis asked for so I submitted a PR to this branch so you don't have to do the same job- feel free to merge my PR to your branch - changes lgtm, tested on FF and Chrome.

@flash1293
Copy link
Contributor Author

Thank you so much @mbondyra 💚

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@MichaelMarcialis
Copy link
Contributor

Hey @flash1293 I wanted to check your PR already with changes @MichaelMarcialis asked for so I submitted a PR to this branch so you don't have to do the same job- feel free to merge my PR to your branch - changes lgtm, tested on FF and Chrome.

This looks lovely. Thanks for making that tweak, @mbondyra!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1011.9KB 1012.1KB +147.0B

Distributable file count

id before after diff
default 46981 47741 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants