Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Geo containment latency and concurrent containment fix #86980

Merged
merged 14 commits into from
Jan 28, 2021

Conversation

kindsun
Copy link
Contributor

@kindsun kindsun commented Dec 28, 2020

Within a single interval, if a tracked entity moves into multiple shapes, one movement per new shape entered generates a single alert. The following are how several movements are handled with the changes introduced in this PR:

  • Intershape into cross-shape movement: 1a -> 1a (alert) -> 1b (alert)
  • Movement into overlapping shapes: 1a (alert) -> 1b (alert), 1c (alert)
  • Movement out of bounds into different shape: 1a (alert) -> 1-OTHER -> 1b (alert). 1a and 1-OTHER movements are NOT carried through to next interval
  • Movement out of bounds back into same shape: 1a -> 1-OTHER -> 1a (alert). Single 1a movement is carried through to next interval
  • Final movement to OTHER: 1a (alert) -> 1-OTHER. No entity 1 movements are carried through to next interval

This sub-interval tracking fixes concurrent containment issues and should also aide with data latency issues

image

@kindsun kindsun added v7.12.0 and removed v7.11.0 labels Jan 26, 2021
@kindsun kindsun marked this pull request as ready for review January 26, 2021 16:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing really jumps out. Some initial comments. Will test a little more, but excited for this fix.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@kindsun kindsun merged commit 80b720d into elastic:master Jan 28, 2021
@kindsun kindsun deleted the geo-containment-latency-fix branch January 28, 2021 16:19
kindsun pushed a commit that referenced this pull request Jan 29, 2021
…86980) (#89586)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants