Add dark-theme version of the Share UI. #8941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
bug
cjcenizal
force-pushed
the
8819/bug/dark-theme-share-ui
branch
from
15178bf
to
70441b5
Compare
|
Rebase or merge master to get the build to go |
- Make share panels 50% width.
cjcenizal
force-pushed
the
8819/bug/dark-theme-share-ui
branch
from
70441b5
to
23141be
Compare
|
Looks great in dashboard, but some of the other non-dark theme places (e.g. discover), it looks a little funny.
|
|
@stacey-gammon good catch, thanks! |
|
@stacey-gammon Fixed! Ready for another review. |
|
LGTM - I checked it out on Chrome and IE 11. |
|
I think I notice an issue but it looks like an existing issue, so LGTM. The issue I'm seeing is that sometimes clicking dashboard flips it back to white theme, sometimes it stays on dark theme. I'll file a separate issue for that as I don't think it's related to this change.
|
stacey-gammon
approved these changes
Nov 10, 2016
cjcenizal
force-pushed
the
8819/bug/dark-theme-share-ui
branch
from
53e759e
to
400ca26
Compare
This was referenced Nov 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8819