-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flights sample data dashboard visualization #89460
Changes from 6 commits
1593102
45ee526
05c869c
4ffe335
595950a
80c5092
7cf0542
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,11 +19,15 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { | |
const renderable = getService('renderable'); | ||
const dashboardExpect = getService('dashboardExpect'); | ||
const PageObjects = getPageObjects(['common', 'header', 'home', 'dashboard', 'timePicker']); | ||
// Added to resolve Failing test: https://github.com/elastic/kibana/issues/89379 | ||
const kibanaServer = getService('kibanaServer'); | ||
|
||
// Failing: See https://github.com/elastic/kibana/issues/89379 | ||
describe.skip('sample data', function describeIndexTests() { | ||
describe('sample data', function describeIndexTests() { | ||
before(async () => { | ||
await security.testUser.setRoles(['kibana_admin', 'kibana_sample_admin']); | ||
await kibanaServer.uiSettings.update({ | ||
'discover:searchFieldsFromSource': true, | ||
}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does it fail without setting There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kertal yes, it works! |
||
await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', { | ||
useActualUrl: true, | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for cleaning, this up!