Add basepath when redirecting from a trailling slash #8966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is basePath guaranteed to end in a |
|
There's some schema validation for it, it'll fail if it ends with a trailing / (or there is only a /) kibana/src/server/config/schema.js Line 42 in aa69744 |
This was referenced Nov 10, 2016
jbudz
pushed a commit
that referenced
this pull request
Nov 10, 2016
jbudz
pushed a commit
that referenced
this pull request
Nov 10, 2016
jbudz
pushed a commit
that referenced
this pull request
Nov 10, 2016
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Nov 10, 2016
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Backports PR elastic#8966 **Commit 1:** Add basepath when redirecting from a trailling slash * Original sha: 442bcb9 * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-11-04T13:33:24Z Former-commit-id: 321e7e5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routes with a trailing slash are redirected with the trailing slash removed. These redirects were not including the server base path causing paths like /my_base_path/app/kibana/ -> /app/kibana