Allow patch level mismatch between Kibana and Elasticsearch #8976
+11
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
reviewed
Nov 4, 2016
| @@ -30,9 +30,9 @@ _Note: The version numbers below are only examples, meant to illustrate the rela | |||
| | ------------------------- | -------------------------- |------------------- | ------- | | |||
| | Versions are the same. | 5.1.2 | 5.1.2 | 💚 OK | | |||
| | ES patch number is newer. | 5.1.__2__ | 5.1.__5__ | ⚠️ Logged warning | | |||
| | ES patch number is older. | 5.1.__2__ | 5.1.__0__ | ⚠️ Logged warning | | |||
There was a problem hiding this comment.
I think we should keep this placement in the original order. I think people will be scanning for conditions and then looking for outcomes, instead of the other way around. In the original order, there's a repeating pattern to aid scanning.
cjcenizal
reviewed
Nov 4, 2016
|
|
||
| it('when majors and minors are equal, but ES patch is less than Kibana patch', () => { | ||
| expect(isEsCompatibleWithKibana('1.1.0', '1.1.1')).to.be(false); | ||
| }); |
There was a problem hiding this comment.
Shouldn't we just change this assertion to be true and move it to the 'returns true' describe block?
There was a problem hiding this comment.
Yes, definitely. Good catch.
Kibana should be able to run against Elasticsearch nodes that are at the same minor version regardless of whether they are at the same patch version. In the event that their patch versions differ, we render a warning.
epixa
force-pushed
the
8515-esversioncheck
branch
from
e2758cb
to
79ea67f
Compare
|
Tested this locally by faking different versions of Kibana. Everything works as expected and the tests pass. LGTM! |
elastic-jasper
added a commit
that referenced
this pull request
Nov 5, 2016
Backports PR #8976 **Commit 1:** Allow patch level mismatch between Kibana and Elasticsearch Kibana should be able to run against Elasticsearch nodes that are at the same minor version regardless of whether they are at the same patch version. In the event that their patch versions differ, we render a warning. * Original sha: 79ea67f * Authored by Court Ewing <court@epixa.com> on 2016-11-04T21:28:46Z
cjcenizal
added a commit
that referenced
this pull request
Nov 5, 2016
Backports PR #8976 **Commit 1:** Allow patch level mismatch between Kibana and Elasticsearch Kibana should be able to run against Elasticsearch nodes that are at the same minor version regardless of whether they are at the same patch version. In the event that their patch versions differ, we render a warning. * Original sha: 79ea67f * Authored by Court Ewing <court@epixa.com> on 2016-11-04T21:28:46Z
cjcenizal
pushed a commit
that referenced
this pull request
Nov 5, 2016
Backports PR #8976 **Commit 1:** Allow patch level mismatch between Kibana and Elasticsearch Kibana should be able to run against Elasticsearch nodes that are at the same minor version regardless of whether they are at the same patch version. In the event that their patch versions differ, we render a warning. * Original sha: 79ea67f * Authored by Court Ewing <court@epixa.com> on 2016-11-04T21:28:46Z
elastic-jasper
added a commit
that referenced
this pull request
Nov 5, 2016
Backports PR #8976 **Commit 1:** Allow patch level mismatch between Kibana and Elasticsearch Kibana should be able to run against Elasticsearch nodes that are at the same minor version regardless of whether they are at the same patch version. In the event that their patch versions differ, we render a warning. * Original sha: 79ea67f * Authored by Court Ewing <court@epixa.com> on 2016-11-04T21:28:46Z
cjcenizal
added a commit
that referenced
this pull request
Nov 5, 2016
Backports PR #8976 **Commit 1:** Allow patch level mismatch between Kibana and Elasticsearch Kibana should be able to run against Elasticsearch nodes that are at the same minor version regardless of whether they are at the same patch version. In the event that their patch versions differ, we render a warning. * Original sha: 79ea67f * Authored by Court Ewing <court@epixa.com> on 2016-11-04T21:28:46Z
cjcenizal
pushed a commit
that referenced
this pull request
Nov 5, 2016
Backports PR #8976 **Commit 1:** Allow patch level mismatch between Kibana and Elasticsearch Kibana should be able to run against Elasticsearch nodes that are at the same minor version regardless of whether they are at the same patch version. In the event that their patch versions differ, we render a warning. * Original sha: 79ea67f * Authored by Court Ewing <court@epixa.com> on 2016-11-04T21:28:46Z
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Nov 10, 2016
…8976) Kibana should be able to run against Elasticsearch nodes that are at the same minor version regardless of whether they are at the same patch version. In the event that their patch versions differ, we render a warning.
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
…8980) Backports PR elastic#8976 **Commit 1:** Allow patch level mismatch between Kibana and Elasticsearch Kibana should be able to run against Elasticsearch nodes that are at the same minor version regardless of whether they are at the same patch version. In the event that their patch versions differ, we render a warning. * Original sha: 79ea67f * Authored by Court Ewing <court@epixa.com> on 2016-11-04T21:28:46Z Former-commit-id: 838b16e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kibana should be able to run against Elasticsearch nodes that are at the
same minor version regardless of whether they are at the same patch
version. In the event that their patch versions differ, we render a
warning.
Fixes #8515