[Alerts] Jira: Disallow labels with spaces #90548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
bug
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
cnasikas
added
release_note:plugin_api_changes
YulNaumenko
reviewed
Feb 8, 2021
| labels: schema.nullable( | ||
| schema.arrayOf( | ||
| schema.string({ | ||
| validate: (label) => |
There was a problem hiding this comment.
Did you try to use RegExp here for the validation?
There was a problem hiding this comment.
No 😄 . Do you want me to?
There was a problem hiding this comment.
It is not a blocker, but could be more extensible.
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
This was referenced Feb 8, 2021
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Feb 8, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/jira/jira.test.tsx # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/jira/jira.tsx
cnasikas
added a commit
that referenced
this pull request
Feb 9, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/jira/jira.test.tsx # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/jira/jira.tsx
cnasikas
added a commit
that referenced
this pull request
Feb 9, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 9, 2021
…timeline-and-rollover-info * 'master' of github.com:elastic/kibana: (47 commits) [Fleet] Use TS project references (elastic#87574) before/beforeEach clean up (elastic#90663) [Vega] user should be able to set a specific tilemap service using the mapStyle property (elastic#88440) [Security Solution][Case] ServiceNow SIR Connector (elastic#88655) [Search Sessions] Enable extend from management (elastic#90558) [ILM] Delete phase redesign (rework) (elastic#90291) [APM-UI][E2E] use withGithubStatus step (elastic#90651) Add folding in kb-monaco and update some viewers (elastic#90152) [Grok Debugger] Changed test to wait for grok debugger container to exist to fix test flakiness (elastic#90543) Strongly typed EUI theme for styled-components (elastic#90106) Fix vega renovate label (elastic#90591) [Uptime] Migrate to TypeScript project references (elastic#90510) [Monitoring] Migrate data source for legacy alerts to monitoring data directly (elastic#87377) [Upgrade Assistant] Add A11y Tests (elastic#90265) [Time to Visualize] Adds functional tests for linking/unlinking panel from embeddable library (elastic#89612) [dev-utils/ship-ci-stats] fail when CI stats is down (elastic#90678) chore(NA): remove write permissions on Bazel remote cache for PRs (elastic#90652) chore(NA): move bazel workspace status from bash script into nodejs executable (elastic#90560) Use default ES distribution for functional tests (elastic#88737) [Alerts] Jira: Disallow labels with spaces (elastic#90548) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/timeline/timeline.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/lib/absolute_timing_to_relative_timing.test.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/lib/absolute_timing_to_relative_timing.ts
cnasikas
removed
the
release_note:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a user creates a JIRA alert action, and adds a label that contains whitespaces, the alert action will get created without any warnings/error messages, but the action will not be able to run successfully. This is due to JIRA not supporting whitespaces in labels. This PR fixes this issue.
Fixes: #90276
Checklist
Delete any items that are not applicable to this PR.
Release note
Jira labels cannot contain spaces. This is due to JIRA not supporting whitespaces in labels.
For maintainers