Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURITY SOLUTION] Fix summary alert details #90657

Merged
merged 1 commit into from
Feb 8, 2021
Merged

[SECURITY SOLUTION] Fix summary alert details #90657

merged 1 commit into from
Feb 8, 2021

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Feb 8, 2021 •
edited
Loading

Summary

Fix summary alert details on flyout -> #90539

Checklist

Delete any items that are not applicable to this PR.

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Team:Threat Hunting Security Solution Threat Hunting Team v7.11.1 labels Feb 8, 2021
@XavierM XavierM self-assigned this Feb 8, 2021
@XavierM XavierM requested review from a team as code owners February 8, 2021 17:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@angorayc
Copy link
Contributor

angorayc commented Feb 8, 2021

Verified, all looks good.
Screenshot 2021-02-09 at 02 22 10

@angorayc angorayc mentioned this pull request Feb 8, 2021
Closed
8 tasks
@FrankHassanabad
Copy link
Contributor

This might have been existing, but tested on Safari, Firefox and Chrome and each reports that an HTML < character is happening when I click the JSON view but I don't think it should hold this PR up but someone should look into that very soon as the browsers are having problems with what is looking like at some point an introduction of some tag soup

Screen Shot 2021-02-08 at 12 21 13 PM

FrankHassanabad
FrankHassanabad approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM mentioned this pull request Feb 8, 2021
Open
@XavierM XavierM merged commit cde3cba into elastic:master Feb 8, 2021
@XavierM XavierM mentioned this pull request Feb 8, 2021
Merged
XavierM added a commit to XavierM/kibana that referenced this pull request Feb 8, 2021
@XavierM
fix summary alert details (elastic#90657)
b37e6a4
XavierM added a commit to XavierM/kibana that referenced this pull request Feb 8, 2021
@XavierM
fix summary alert details (elastic#90657)
d9aa0a5
@XavierM XavierM mentioned this pull request Feb 8, 2021
Merged
angorayc added a commit that referenced this pull request Feb 9, 2021
@XavierM @angorayc
[7.11] fix summary alert details (#90657) (#90685)
f8de6d2 
* fix summary alert details (#90657)

* update expected data

Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>
angorayc added a commit that referenced this pull request Feb 9, 2021
@XavierM @angorayc
[7.x] fix summary alert details (#90657) (#90684)
56ae5c5 
* fix summary alert details (#90657)

* update expected data

Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

@angorayc angorayc angorayc approved these changes

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees

@XavierM XavierM

Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.11.1 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XavierM @elasticmachine @angorayc @FrankHassanabad @kibanamachine @michaelolo24