Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y kibana overview test - changed the order of the tests being run. #90876

Merged
merged 21 commits into from
Feb 17, 2021

Conversation

rashmivkulkarni
Copy link
Contributor

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@rashmivkulkarni
Copy link
Contributor Author

@rashmivkulkarni rashmivkulkarni added the release_note:skip Skip the PR/issue when compiling release notes label Feb 10, 2021
@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should wait for lens fix to get in and review before merging.

@bhavyarm
Copy link
Contributor

@rashmivkulkarni I was thinking about this & we actually don't need to install sample data in accessibility/kibana_overview.ts because we are testing that part in accessibility/home.ts where it passes. So Rashmi's skipped a11y test fix can either delete that piece of code or merge this part into home.ts " await PageObjects.common.navigateToApp('kibanaOverview');"
cc @myasonik

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

Have taken out adding/removal of sample data test out of this file as it was already covered in /test/accessibility/apps/home.ts

@rashmivkulkarni rashmivkulkarni added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Feb 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Copy link
Contributor

@cqliu1 cqliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rashmivkulkarni
Copy link
Contributor Author

@bhavyarm - second review please.

@bhavyarm
Copy link
Contributor

LGTM @rashmivkulkarni thanks!

@rashmivkulkarni rashmivkulkarni merged commit 43e6a14 into elastic:master Feb 17, 2021
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Feb 17, 2021
…elastic#90876)

* fixes elastic#74449

* changed the order of the tests

* removed a test as it was already covered in home.ts and reoved sampledata

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
rashmivkulkarni added a commit that referenced this pull request Feb 17, 2021
…#90876) (#91681)

* fixes #74449

* changed the order of the tests

* removed a test as it was already covered in home.ts and reoved sampledata

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc test_xpack_functional v7.12.0 v8.0.0
Projects
None yet
5 participants