Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async loading of spaces assets #91018

Closed
wants to merge 1 commit into from
Closed

Async loading of spaces assets #91018

wants to merge 1 commit into from

Conversation

legrego
Copy link
Member

@legrego legrego commented Feb 10, 2021 •
edited
Loading

Summary

Work in progress.

Moves the spaces management assets outside of Kibana's entry bundle.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
spaces 41.2KB 129.2KB +88.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
spaces 231.3KB 157.9KB -73.3KB
Unknown metric groups

async chunk count

id before after diff
spaces 1 3 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego mentioned this pull request Feb 22, 2021
Merged
@legrego
Copy link
Member Author

legrego commented Mar 2, 2021

Superseded by #91976

@legrego legrego closed this Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legrego @kibanamachine