-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup spaces plugin #91976
Cleanup spaces plugin #91976
Commits on Feb 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for fad2f42 - Browse repository at this point
Copy the full SHA fad2f42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 388206d - Browse repository at this point
Copy the full SHA 388206dView commit details -
Temporarily remove
import type
directiveThis is needed to use the import sorter
Configuration menu - View commit details
-
Copy full SHA for dc49b70 - Browse repository at this point
Copy the full SHA dc49b70View commit details -
Sort order 1. External dependencies 2. Internal absolute dependencies (@kbn/..., src/...) 3. Internal relative dependencies Also cleaned up some relative dependencies in the process.
Configuration menu - View commit details
-
Copy full SHA for 25a9066 - Browse repository at this point
Copy the full SHA 25a9066View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97cc9bb - Browse repository at this point
Copy the full SHA 97cc9bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ad077f - Browse repository at this point
Copy the full SHA 4ad077fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f022c4c - Browse repository at this point
Copy the full SHA f022c4cView commit details -
An error was getting logged to the console because jsdom does not support window.location.reload() out of the box.
Configuration menu - View commit details
-
Copy full SHA for 59a921c - Browse repository at this point
Copy the full SHA 59a921cView commit details -
Rename it from 'CopySavedObjectsToSpaceFlyout' to 'CopyToSpaceFlyoutInternal'.
Configuration menu - View commit details
-
Copy full SHA for 6284843 - Browse repository at this point
Copy the full SHA 6284843View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0872427 - Browse repository at this point
Copy the full SHA 0872427View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9341c0c - Browse repository at this point
Copy the full SHA 9341c0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0080228 - Browse repository at this point
Copy the full SHA 0080228View commit details -
Rename it from 'SpaceAvatar' to 'SpaceAvatarInternal'
Configuration menu - View commit details
-
Copy full SHA for f3126fd - Browse repository at this point
Copy the full SHA f3126fdView commit details -
This was statically imported by the Security plugin so it required quite a bit of refactoring.
Configuration menu - View commit details
-
Copy full SHA for 9b6cf54 - Browse repository at this point
Copy the full SHA 9b6cf54View commit details -
Remove dependency on @kbn/std package
Reduces page load bundle by 29KB
Configuration menu - View commit details
-
Copy full SHA for c922c54 - Browse repository at this point
Copy the full SHA c922c54View commit details -
Change CTS flyout to use SpacesContext
Thought this would decrease the page load bundle size, but it only shaved off a few hundred bytes. At any rate, this change cleans up the code a bit, and will be needed when we eventually expose this as a reusable component for outside consumers.
Configuration menu - View commit details
-
Copy full SHA for b8d93b0 - Browse repository at this point
Copy the full SHA b8d93b0View commit details
Commits on Feb 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6242d1a - Browse repository at this point
Copy the full SHA 6242d1aView commit details -
Abstract out lazy-loading from reusable components
Components exposed in the public contract are now wrapped and automatically lazy-loaded. Consumers no longer have to handle this.
Configuration menu - View commit details
-
Copy full SHA for a21ca9a - Browse repository at this point
Copy the full SHA a21ca9aView commit details -
Use error boundaries when lazy-loading components
If we have an exception where we do not use an error boundary, I added a comment explaining why. I also standardized our usages of `lazy` and `Suspense` by destructuring the React import.
Configuration menu - View commit details
-
Copy full SHA for 032b5cb - Browse repository at this point
Copy the full SHA 032b5cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for bebf3b2 - Browse repository at this point
Copy the full SHA bebf3b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b792353 - Browse repository at this point
Copy the full SHA b792353View commit details -
Configuration menu - View commit details
-
Copy full SHA for 181ddcb - Browse repository at this point
Copy the full SHA 181ddcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2612620 - Browse repository at this point
Copy the full SHA 2612620View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b6554b - Browse repository at this point
Copy the full SHA 1b6554bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b6c5e5 - Browse repository at this point
Copy the full SHA 1b6c5e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38fb012 - Browse repository at this point
Copy the full SHA 38fb012View commit details
Commits on Mar 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 99ab44c - Browse repository at this point
Copy the full SHA 99ab44cView commit details