Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup spaces plugin #91976

Merged
merged 27 commits into from
Mar 1, 2021
Merged

Cleanup spaces plugin #91976

merged 27 commits into from
Mar 1, 2021

Commits on Feb 22, 2021

  1. Configuration menu
    Copy the full SHA
    fad2f42 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    388206d View commit details
    Browse the repository at this point in the history
  3. Temporarily remove import type directive

    This is needed to use the import sorter
    jportner committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    dc49b70 View commit details
    Browse the repository at this point in the history
  4. Sort imports

    Sort order
    1. External dependencies
    2. Internal absolute dependencies (@kbn/..., src/...)
    3. Internal relative dependencies
    
    Also cleaned up some relative dependencies in the process.
    jportner committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    25a9066 View commit details
    Browse the repository at this point in the history
  5. Apply import type directive

    Adds ESLint rule to enforce this.
    jportner committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    97cc9bb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4ad077f View commit details
    Browse the repository at this point in the history
  7. Reduce bundle size

    Splits out most components into separate chunks
    jportner committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    f022c4c View commit details
    Browse the repository at this point in the history
  8. Fix jest test error

    An error was getting logged to the console because jsdom does not
    support window.location.reload() out of the box.
    jportner committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    59a921c View commit details
    Browse the repository at this point in the history
  9. Refactor CTS flyout

    Rename it from 'CopySavedObjectsToSpaceFlyout' to
    'CopyToSpaceFlyoutInternal'.
    jportner committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    6284843 View commit details
    Browse the repository at this point in the history
  10. Move summarizeCopyResult

    jportner committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    0872427 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9341c0c View commit details
    Browse the repository at this point in the history
  12. Lazy load NavControlPopover

    jportner committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    0080228 View commit details
    Browse the repository at this point in the history
  13. Refactor SpaceAvatar

    Rename it from 'SpaceAvatar' to 'SpaceAvatarInternal'
    jportner committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    f3126fd View commit details
    Browse the repository at this point in the history
  14. Lazy load SpaceAvatar

    This was statically imported by the Security plugin so it required
    quite a bit of refactoring.
    jportner committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    9b6cf54 View commit details
    Browse the repository at this point in the history
  15. Remove dependency on @kbn/std package

    Reduces page load bundle by 29KB
    jportner committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    c922c54 View commit details
    Browse the repository at this point in the history
  16. Change CTS flyout to use SpacesContext

    Thought this would decrease the page load bundle size, but it only
    shaved off a few hundred bytes. At any rate, this change cleans up
    the code a bit, and will be needed when we eventually expose this
    as a reusable component for outside consumers.
    jportner committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    b8d93b0 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Configuration menu
    Copy the full SHA
    6242d1a View commit details
    Browse the repository at this point in the history
  2. Abstract out lazy-loading from reusable components

    Components exposed in the public contract are now wrapped and
    automatically lazy-loaded. Consumers no longer have to handle this.
    jportner committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    a21ca9a View commit details
    Browse the repository at this point in the history
  3. Use error boundaries when lazy-loading components

    If we have an exception where we do not use an error boundary, I
    added a comment explaining why.
    I also standardized our usages of `lazy` and `Suspense` by
    destructuring the React import.
    jportner committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    032b5cb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bebf3b2 View commit details
    Browse the repository at this point in the history
  5. Fix type check for unit test

    jportner committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    b792353 View commit details
    Browse the repository at this point in the history
  6. Fix i18n error

    jportner committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    181ddcb View commit details
    Browse the repository at this point in the history
  7. Remove unused parameter

    jportner committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    2612620 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1b6554b View commit details
    Browse the repository at this point in the history
  9. PR review feedback

    jportner committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    1b6c5e5 View commit details
    Browse the repository at this point in the history
  10. Fix jest unit tests

    jportner committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    38fb012 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Configuration menu
    Copy the full SHA
    99ab44c View commit details
    Browse the repository at this point in the history