Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix geo_shape content causing Data Visualizer to not load correctly #92052

Merged
merged 3 commits into from
Feb 22, 2021
Merged

[ML] Fix geo_shape content causing Data Visualizer to not load correctly #92052

merged 3 commits into from
Feb 22, 2021

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Feb 19, 2021 •
edited
Loading

Summary

This PR fixes the Data Visualizer not successfully querying aggregation stats when at least one of the fields is of type geo_shape. This issue happens in 7.10, 7.11, and 7.12.

Before
Screen Shot 2021-02-19 at 10 01 06

After (7.10)
Screen Shot 2021-02-19 at 12 36 16

After (7.11 & 7.12)
Screen Shot 2021-02-19 at 11 40 57

@qn895 qn895 added bug Fixes for quality problems that affect the customer experience release_note:fix :ml v8.0.0 Feature:File and Index Data Viz ML file and index data visualizer v7.12.0 v7.10.3 v7.11.2 labels Feb 19, 2021
@qn895 qn895 self-assigned this Feb 19, 2021
@qn895 qn895 requested a review from a team as a code owner February 19, 2021 17:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member Author

qn895 commented Feb 19, 2021

@elasticmachine merge upstream

@qn895 qn895 mentioned this pull request Feb 22, 2021
Merged
peteharverson
peteharverson approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

jgowdyelastic
jgowdyelastic approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qn895
Copy link
Member Author

qn895 commented Feb 22, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.4MB 6.4MB +56.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895 qn895 added auto-backport Deprecated - use backport:version if exact versions are needed and removed v7.10.3 labels Feb 22, 2021
@qn895 qn895 merged commit 0024f28 into elastic:master Feb 22, 2021
@qn895 qn895 deleted the ml-dv-geo-shape-7.10 branch February 22, 2021 17:38
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Feb 22, 2021
@qn895 @kibanamachine
[ML] Fix geo_shape content causing Data Visualizer to not load correc…
10bb48d 
…tly (elastic#92052)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Feb 22, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Feb 22, 2021
@qn895 @kibanamachine
[ML] Fix geo_shape content causing Data Visualizer to not load correc…
72241c6 
…tly (elastic#92052)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Feb 22, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.11 / #92247
✅ 7.12 / #92248

Successful backport PRs will be merged automatically after passing CI.

@qn895 qn895 mentioned this pull request Feb 22, 2021
Merged
qn895 added a commit to qn895/kibana that referenced this pull request Feb 22, 2021
@qn895 @kibanamachine
[ML] Fix geo_shape content causing Data Visualizer to not load correc…
3b9c5ea 
…tly (elastic#92052)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Feb 22, 2021
@kibanamachine @qn895
[ML] Fix geo_shape content causing Data Visualizer to not load correc…
e545171 
…tly (#92052) (#92247)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Feb 22, 2021
@kibanamachine @qn895
[ML] Fix geo_shape content causing Data Visualizer to not load correc…
55f7608 
…tly (#92052) (#92248)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
qn895 added a commit that referenced this pull request Feb 22, 2021
@qn895 @kibanamachine
[ML] Fix geo_shape content causing Data Visualizer to not load correc…
e0f3464 
…tly (#92052) (#92249)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@qn895 qn895

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:File and Index Data Viz ML file and index data visualizer :ml release_note:fix v7.11.2 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qn895 @elasticmachine @kibanamachine @peteharverson @jgowdyelastic