Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Search] Remove external/popout icon from Create Engine CTA #92272

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Feb 22, 2021

Summary

Now that create engine button is no longer linking externally to the standalone UI, we no longer need this icon.

I missed this while reviewing #89816, totally my bad!

Before

After

- now that create engine is no longer linking out to standalone UI
@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 22, 2021
@cee-chen cee-chen requested a review from a team February 22, 2021 19:40
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1751 1736 -15

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.3MB 5.2MB -33.8KB
enterpriseSearch 1.9MB 1.9MB -18.0B
total -33.8KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen enabled auto-merge (squash) February 22, 2021 23:14
@cee-chen cee-chen merged commit 80f697d into elastic:master Feb 23, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 23, 2021
- now that create engine is no longer linking out to standalone UI
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #92407

Successful backport PRs will be merged automatically after passing CI.

@cee-chen cee-chen deleted the create-engines-icon branch February 23, 2021 15:50
kibanamachine added a commit that referenced this pull request Feb 23, 2021
- now that create engine is no longer linking out to standalone UI

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants