[APM] Include services with only metric documents #92378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
reviewed
Feb 24, 2021
| * 2.0. | ||
| */ | ||
|
|
||
| export function asMutableArray<T extends Readonly<any>>( |
There was a problem hiding this comment.
Can you add a comment to describe what this helper does?
sorenlouv
reviewed
Feb 24, 2021
Comment on lines
50
to
53
| getHealthStatuses(params).catch((err) => { | ||
| logger.error(err); | ||
| return []; | ||
| }), |
There was a problem hiding this comment.
nit: shouldn't the error handling happen in getHealthStatuses?
sorenlouv
approved these changes
Feb 24, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 1, 2021
* master: [Logs UI] Round up the end timestamp in the log stream embeddable (elastic#92833) skip flaky suite (elastic#91939) skip flaky suite (elastic#89072) [APM] Include services with only metric documents (elastic#92378)
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Mar 2, 2021
* [APM] Include services with only metric documents Closes elastic#92075. * Explain as_mutable_array * Use kuery instead of uiFilters for API tests
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added
backport missing
dgieselaar
added a commit
that referenced
this pull request
Mar 2, 2021
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Mar 2, 2021
* [APM] Include services with only metric documents Closes elastic#92075. * Explain as_mutable_array * Use kuery instead of uiFilters for API tests # Conflicts: # x-pack/plugins/apm/server/lib/services/get_services/get_services_items.ts
dgieselaar
added a commit
that referenced
this pull request
Mar 4, 2021
…3211) * [APM] Include services with only metric documents (#92378) * [APM] Include services with only metric documents Closes #92075. * Explain as_mutable_array * Use kuery instead of uiFilters for API tests # Conflicts: # x-pack/plugins/apm/server/lib/services/get_services/get_services_items.ts * Use uiFilters in API tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
|
tests ok |
cauemarcondes
added
the
apm:test-plan-done
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92075.
Before:
After: