Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actions][Docs] Moving subaction and subaction params back to README #92878

Merged
merged 6 commits into from
Mar 2, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Feb 25, 2021

Summary

As part of #91789, I moved all the action type params to the user docs. However, for the ServiceNow, Jira and IBM Reslient actions, the details of subaction type and subaction params are not visible at a user level so they shouldn't be in the user docs. This PR moves the subaction types and params back to the README and reverts to user docs to just showing the fields a user can fill out.

Checklist

  • Documentation was added for features that require explanation or tutorials

@ymao1 ymao1 self-assigned this Feb 25, 2021
@ymao1 ymao1 added Feature:Actions release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v7.13.0 v8.0.0 labels Feb 25, 2021
@ymao1 ymao1 marked this pull request as ready for review February 25, 2021 18:27
@ymao1 ymao1 requested a review from a team as a code owner February 25, 2021 18:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@ymao1
Copy link
Contributor Author

ymao1 commented Mar 1, 2021

@elasticmachine merge upstream

docs/user/alerting/action-types/jira.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/action-types/jira.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/action-types/jira.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/action-types/resilient.asciidoc Outdated Show resolved Hide resolved
x-pack/plugins/actions/README.md Outdated Show resolved Hide resolved
x-pack/plugins/actions/README.md Outdated Show resolved Hide resolved
x-pack/plugins/actions/README.md Outdated Show resolved Hide resolved
x-pack/plugins/actions/README.md Outdated Show resolved Hide resolved
x-pack/plugins/actions/README.md Outdated Show resolved Hide resolved
x-pack/plugins/actions/README.md Outdated Show resolved Hide resolved
@ymao1 ymao1 requested a review from gchaps March 1, 2021 21:00
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.0KB 104.1KB +82.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gmmorris gmmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1 ymao1 added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 2, 2021
@ymao1 ymao1 merged commit 3dd3297 into elastic:master Mar 2, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 2, 2021
…lastic#92878)

* Moving subaction and subaction params back to README

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* PR fixes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 2, 2021
…lastic#92878)

* Moving subaction and subaction params back to README

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* PR fixes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.12 / #93281
7.x / #93283

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 2, 2021
…92878) (#93281)

* Moving subaction and subaction params back to README

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* PR fixes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: ymao1 <ying.mao@elastic.co>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Mar 2, 2021
…92878) (#93283)

* Moving subaction and subaction params back to README

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* PR fixes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: ymao1 <ying.mao@elastic.co>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@ymao1 ymao1 deleted the actions/readme-again branch March 25, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Actions release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants