[Security Solution][Case] Show the current connector name in case view #93018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
| .find('[data-test-subj="has-data-to-push-button"]') | ||
| .first() | ||
| .text() | ||
| .includes('My Connector 2') |
There was a problem hiding this comment.
Sorry for the dumb question but how does the new name get set? Is it changed by a different test? Or in one of the mock implementations above?
There was a problem hiding this comment.
Hey! It is set in useConnectorsMock.mockImplementation(() => ({ connectors: connectorsMock, loading: false }));.
jonathan-buttner
approved these changes
Mar 1, 2021
This was referenced Mar 1, 2021
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Mar 1, 2021
cnasikas
added a commit
that referenced
this pull request
Mar 1, 2021
cnasikas
added a commit
that referenced
this pull request
Mar 1, 2021
tsullivan
pushed a commit
to tsullivan/kibana
that referenced
this pull request
Mar 1, 2021
jloleysens
added a commit
that referenced
this pull request
Mar 3, 2021
… ilm/rollup-v2-action * 'ilm/rollup-v2-action' of github.com:elastic/kibana: [Security Solution][Case][Bug] Only add rule object for alert comments (#92977) [Security Solution][Case] Show the current connector name in case view (#93018) [Security Solution] Remove unused mock data (#92357) Adds mapping to the signals for the indicator rules that were missing (#92928) skip flaky suite (#85208) Cleanup spaces plugin (#91976) Control round and decimal places in Gauge Visualization when using aggregate functions like average (#91293) Added alerting ui mock for jest test (#92604) Remove "beta" label from URL Drilldown as it is now GA (#92859)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you create a case with a connector selected the name of the connector is being saved in the case's saved object. Specifically:
connector: {id: string; name: string; ...}. If you update the connector, the name is not updated in the case's saved object because the updating is happening on the action's side and we do not have a way to update our information after an action's update. This PR fixes this issue as the name of the connector is taken from the up to date list of all current connectors.Fixes: #92607
Checklist
Delete any items that are not applicable to this PR.
For maintainers