Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Cleanup spaces plugin (#91976) #93032

Merged
merged 3 commits into from
Mar 1, 2021

Conversation

jportner
Copy link
Contributor

@jportner jportner commented Mar 1, 2021

Backports the following commits to 7.x:

# Conflicts:
#	x-pack/plugins/security/public/management/roles/roles_management_app.tsx
@jportner jportner enabled auto-merge (squash) March 1, 2021 13:57
@jportner
Copy link
Contributor Author

jportner commented Mar 1, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
spaces 270 259 -11

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.4MB 6.4MB +229.0B
savedObjectsManagement 163.8KB 163.8KB -20.0B
security 723.8KB 724.3KB +484.0B
spaces 41.5KB 309.3KB ⚠️ +267.8KB
triggersActionsUi 1.6MB 1.5MB -23.9KB
total +244.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
security 131.0KB 131.1KB +104.0B
spaces 274.7KB 44.6KB -230.1KB
spacesOss 4.5KB 4.7KB +212.0B
triggersActionsUi 104.0KB 104.1KB +82.0B
total -229.7KB
Unknown metric groups

async chunk count

id before after diff
spaces 1 10 +9
triggersActionsUi 41 42 +1
total +10

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner merged commit f61d1d3 into elastic:7.x Mar 1, 2021
@jportner jportner deleted the backport/7.x/pr-91976 branch March 1, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants