Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test huge fields functional test #93334

Merged
merged 26 commits into from
Mar 3, 2021

Conversation

rashmivkulkarni
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni commented Mar 2, 2021

fixes #89031
This test was skipped in master due to an error like this retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="createIndexPatternTimeFieldSelect"]). It was not navigating to the Management page , so added the navigateTo().
Ran this multiple times locally ( as an individual test and also the entire CIGroup8 which it belongs to)

Also a quick note about the esArchiver. Although it did have the Date filed in the metadata, results weren't showing up in Discover for a large time range, so modified the esArchiver accordingly to reflect the Date field, and results were shown in Discover, upon loading the dataset.

@rashmivkulkarni rashmivkulkarni added test_ui_functional v8.0.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Mar 2, 2021
@rashmivkulkarni rashmivkulkarni self-assigned this Mar 2, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rashmivkulkarni

Copy link
Contributor

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code review and Jenkins results

@rashmivkulkarni rashmivkulkarni added the Feature:Index Management Index and index templates UI label Mar 3, 2021
@rashmivkulkarni rashmivkulkarni removed the request for review from alisonelizabeth March 3, 2021 16:53
@rashmivkulkarni
Copy link
Contributor Author

@elastic/kibana-app-services need a review plz.

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rashmivkulkarni rashmivkulkarni merged commit a0881f9 into elastic:master Mar 3, 2021
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Mar 3, 2021
* fixes elastic#74449

* fix for unskipping test huge fields functional test

* fix eslint
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Mar 3, 2021
* fixes elastic#74449

* fix for unskipping test huge fields functional test

* fix eslint
rashmivkulkarni added a commit that referenced this pull request Mar 3, 2021
* fixes #74449

* fix for unskipping test huge fields functional test

* fix eslint
rashmivkulkarni added a commit that referenced this pull request Mar 3, 2021
* fixes #74449

* fix for unskipping test huge fields functional test

* fix eslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Index Management Index and index templates UI Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.12.0 v8.0.0
Projects
None yet
4 participants