Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint rules for Spaces and Security #93644

Merged
merged 2 commits into from
Mar 4, 2021
Merged

ESLint rules for Spaces and Security #93644

merged 2 commits into from
Mar 4, 2021

Conversation

jportner
Copy link
Contributor

@jportner jportner commented Mar 4, 2021

Follow-on to #91976 and #93056.

In that PR, I used a VS Code plugin to sort import declarations and multiple import members into the correct order, but this will result in drift over time.

In this PR, we use eslint-plugin-import rules to ensure that import declarations are sorted, and the built-in sort-imports rule to ensure that multiple import members (destructured imports) are sorted.

@jportner
Enforce import declaration sort order using ESLint
742ece0 
The established sort order is now enforced using ESLint rules via the
eslint-plugin-import package.
@jportner
Enforce sort order for multiple import members using ESLint
37ad3c9
@jportner jportner added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 4, 2021
@jportner jportner requested a review from legrego March 4, 2021 17:19
@jportner jportner marked this pull request as ready for review March 4, 2021 17:19
@jportner jportner requested a review from a team as a code owner March 4, 2021 17:19
@jportner jportner enabled auto-merge (squash) March 4, 2021 17:19
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / general / X-Pack Spaces API Integration Tests -- security_and_spaces.x-pack/test/spaces_api_integration/security_and_spaces/apis/delete·ts.spaces api with security delete superuser from the space_1 space should return 204 when referencing the space_1 space explicitly in the URL

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/92358

[00:00:00]       │
[00:00:00]         └-: spaces api with security
[00:00:00]           └-> "before all" hook in "spaces api with security"
[00:00:00]           └-> "before all" hook in "spaces api with security"
[00:00:00]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] [.ds-ilm-history-5-2021.03.04-000001] creating index, cause [initialize_data_stream], templates [ilm-history], shards [1]/[0]
[00:00:00]             │ info [o.e.c.m.MetadataCreateDataStreamService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] adding data stream [ilm-history-5] with write index [.ds-ilm-history-5-2021.03.04-000001] and backing indices []
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_legacy_user]
[00:00:00]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.ds-ilm-history-5-2021.03.04-000001][0]]])." previous.health="YELLOW" reason="shards started [[.ds-ilm-history-5-2021.03.04-000001][0]]"
[00:00:00]             │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] moving index [.ds-ilm-history-5-2021.03.04-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [ilm-history-ilm-policy]
[00:00:00]             │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] moving index [.ds-ilm-history-5-2021.03.04-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [ilm-history-ilm-policy]
[00:00:00]             │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] moving index [.ds-ilm-history-5-2021.03.04-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [ilm-history-ilm-policy]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_dual_privileges_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_dual_privileges_dashboard_only_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_rbac_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_rbac_dashboard_only_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_rbac_default_space_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_rbac_default_space_read_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_rbac_space_1_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_rbac_space_1_read_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_rbac_space_2_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_rbac_space_2_read_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_rbac_space_1_2_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_rbac_space_1_2_read_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_rbac_default_space_saved_objects_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_rbac_default_space_saved_objects_read_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_rbac_space_1_saved_objects_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added role [kibana_rbac_space_1_saved_objects_read_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [not_a_kibana_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_legacy_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_dual_privileges_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_dual_privileges_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_rbac_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_rbac_dashboard_only_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_rbac_default_space_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_rbac_default_space_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_rbac_space_1_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_rbac_space_1_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_rbac_space_2_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_rbac_space_2_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_rbac_space_1_2_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_rbac_space_1_2_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_rbac_default_space_saved_objects_all_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_rbac_default_space_saved_objects_read_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_rbac_space_1_saved_objects_all_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_kibana_rbac_space_1_saved_objects_read_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_apm_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_machine_learning_admin]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_machine_learning_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] added user [a_monitoring_user]
[00:03:54]           └-: delete
[00:03:54]             └-> "before all" hook in "delete"
[00:04:56]             └-: superuser from the space_1 space
[00:04:56]               └-> "before all" hook for "should return 204 when referencing the space_1 space explicitly in the URL"
[00:04:56]               └-> should return 204 when referencing the space_1 space explicitly in the URL
[00:04:56]                 └-> "before each" hook: global before each for "should return 204 when referencing the space_1 space explicitly in the URL"
[00:04:56]                 └-> "before each" hook for "should return 204 when referencing the space_1 space explicitly in the URL"
[00:04:56]                   │ info [saved_objects/spaces] Loading "mappings.json"
[00:04:56]                   │ info [saved_objects/spaces] Loading "data.json"
[00:04:56]                   │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] [.kibana_task_manager_8.0.0_001/UyL6l606TmK-TNB3RKtXQg] deleting index
[00:04:56]                   │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] [.kibana_8.0.0_001/atQdTFz2QNqWMfjzK8tPRA] deleting index
[00:04:56]                   │ info [saved_objects/spaces] Deleted existing index ".kibana_8.0.0_001"
[00:04:56]                   │ info [saved_objects/spaces] Deleted existing index ".kibana_task_manager_8.0.0_001"
[00:04:56]                   │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] [.kibana_8.0.0_001] creating index, cause [api], templates [], shards [1]/[0]
[00:04:56]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_8.0.0_001][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_8.0.0_001][0]]"
[00:04:56]                   │ info [saved_objects/spaces] Created index ".kibana_8.0.0_001"
[00:04:56]                   │ debg [saved_objects/spaces] ".kibana_8.0.0_001" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:04:56]                   │ info [saved_objects/spaces] Indexed 31 docs into ".kibana"
[00:04:56]                   │ debg Migrating saved objects
[00:04:56]                   │ proc [kibana]   log   [18:04:01.433] [warning][collector-set][plugins][usageCollection] ResponseError: index_not_found_exception
[00:04:56]                   │ proc [kibana]     at onBody (/dev/shm/workspace/kibana-build-xpack-13/node_modules/@elastic/elasticsearch/lib/Transport.js:333:23)
[00:04:56]                   │ proc [kibana]     at IncomingMessage.onEnd (/dev/shm/workspace/kibana-build-xpack-13/node_modules/@elastic/elasticsearch/lib/Transport.js:260:11)
[00:04:56]                   │ proc [kibana]     at IncomingMessage.emit (events.js:327:22)
[00:04:56]                   │ proc [kibana]     at endReadableNT (internal/streams/readable.js:1327:12)
[00:04:56]                   │ proc [kibana]     at processTicksAndRejections (internal/process/task_queues.js:80:21) {
[00:04:56]                   │ proc [kibana]   meta: {
[00:04:56]                   │ proc [kibana]     body: { error: [Object], status: 404 },
[00:04:56]                   │ proc [kibana]     statusCode: 404,
[00:04:56]                   │ proc [kibana]     headers: {
[00:04:56]                   │ proc [kibana]       'content-type': 'application/json;charset=utf-8',
[00:04:56]                   │ proc [kibana]       'content-length': '449'
[00:04:56]                   │ proc [kibana]     },
[00:04:56]                   │ proc [kibana]     meta: {
[00:04:56]                   │ proc [kibana]       context: null,
[00:04:56]                   │ proc [kibana]       request: [Object],
[00:04:56]                   │ proc [kibana]       name: 'elasticsearch-js',
[00:04:56]                   │ proc [kibana]       connection: [Object],
[00:04:56]                   │ proc [kibana]       attempts: 0,
[00:04:56]                   │ proc [kibana]       aborted: false
[00:04:56]                   │ proc [kibana]     }
[00:04:56]                   │ proc [kibana]   }
[00:04:56]                   │ proc [kibana] }
[00:04:56]                   │ proc [kibana]   log   [18:04:01.440] [warning][collector-set][plugins][usageCollection] Unable to fetch data from core collector
[00:04:56]                   │ proc [kibana]   log   [18:04:01.666] [warning][collector-set][plugins][usageCollection] ResponseError: search_phase_execution_exception
[00:04:56]                   │ proc [kibana]     at onBody (/dev/shm/workspace/kibana-build-xpack-13/node_modules/@elastic/elasticsearch/lib/Transport.js:333:23)
[00:04:56]                   │ proc [kibana]     at IncomingMessage.onEnd (/dev/shm/workspace/kibana-build-xpack-13/node_modules/@elastic/elasticsearch/lib/Transport.js:260:11)
[00:04:56]                   │ proc [kibana]     at IncomingMessage.emit (events.js:327:22)
[00:04:56]                   │ proc [kibana]     at endReadableNT (internal/streams/readable.js:1327:12)
[00:04:56]                   │ proc [kibana]     at processTicksAndRejections (internal/process/task_queues.js:80:21) {
[00:04:56]                   │ proc [kibana]   meta: {
[00:04:56]                   │ proc [kibana]     body: { error: [Object], status: 400 },
[00:04:56]                   │ proc [kibana]     statusCode: 400,
[00:04:56]                   │ proc [kibana]     headers: {
[00:04:56]                   │ proc [kibana]       'content-type': 'application/json;charset=utf-8',
[00:04:56]                   │ proc [kibana]       'content-length': '752'
[00:04:56]                   │ proc [kibana]     },
[00:04:56]                   │ proc [kibana]     meta: {
[00:04:56]                   │ proc [kibana]       context: null,
[00:04:56]                   │ proc [kibana]       request: [Object],
[00:04:56]                   │ proc [kibana]       name: 'elasticsearch-js',
[00:04:56]                   │ proc [kibana]       connection: [Object],
[00:04:56]                   │ proc [kibana]       attempts: 0,
[00:04:56]                   │ proc [kibana]       aborted: false
[00:04:56]                   │ proc [kibana]     }
[00:04:56]                   │ proc [kibana]   }
[00:04:56]                   │ proc [kibana] }
[00:04:56]                   │ proc [kibana]   log   [18:04:01.667] [warning][collector-set][plugins][usageCollection] Unable to fetch data from saved_objects_tagging collector
[00:04:56]                   │ proc [kibana]   log   [18:04:01.751] [info][savedobjects-service] [.kibana_task_manager] INIT -> CREATE_NEW_TARGET
[00:04:56]                   │ proc [kibana]   log   [18:04:01.754] [info][savedobjects-service] [.kibana] INIT -> OUTDATED_DOCUMENTS_SEARCH
[00:04:56]                   │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] [.kibana_task_manager_8.0.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:04:56]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] updating number_of_replicas to [0] for indices [.kibana_task_manager_8.0.0_001]
[00:04:57]                   │ proc [kibana]   log   [18:04:01.781] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH -> UPDATE_TARGET_MAPPINGS
[00:04:57]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_task_manager_8.0.0_001][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_task_manager_8.0.0_001][0]]"
[00:04:57]                   │ proc [kibana]   log   [18:04:01.803] [info][savedobjects-service] [.kibana_task_manager] CREATE_NEW_TARGET -> MARK_VERSION_INDEX_READY
[00:04:57]                   │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] [.kibana_8.0.0_001/280VoCKWRqO3oQF_GptFqg] update_mapping [_doc]
[00:04:57]                   │ proc [kibana]   log   [18:04:01.850] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK
[00:04:57]                   │ proc [kibana]   log   [18:04:01.860] [info][savedobjects-service] [.kibana_task_manager] MARK_VERSION_INDEX_READY -> DONE
[00:04:57]                   │ proc [kibana]   log   [18:04:01.860] [info][savedobjects-service] [.kibana_task_manager] Migration completed after 182ms
[00:04:57]                   │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] 55271 finished with response BulkByScrollResponse[took=20.6ms,timed_out=false,sliceId=null,updated=31,created=0,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:04:57]                   │ proc [kibana]   log   [18:04:01.965] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> DONE
[00:04:57]                   │ proc [kibana]   log   [18:04:01.965] [info][savedobjects-service] [.kibana] Migration completed after 287ms
[00:04:57]                   │ debg [saved_objects/spaces] Migrated Kibana index after loading Kibana data
[00:04:57]                   │ debg [saved_objects/spaces] Ensured that default space exists in .kibana
[00:04:57]                   │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1614878211551593316] [.kibana_8.0.0_001/280VoCKWRqO3oQF_GptFqg] update_mapping [_doc]
[00:04:58]                 └- ✖ fail: spaces api with security delete superuser from the space_1 space should return 204 when referencing the space_1 space explicitly in the URL
[00:04:58]                 │       Error: expected [ { key: 'default',
[00:04:58]                 │     doc_count: 8,
[00:04:58]                 │     countByType: 
[00:04:58]                 │      { doc_count_error_upper_bound: 0,
[00:04:58]                 │        sum_other_doc_count: 0,
[00:04:58]                 │        buckets: [Object] } },
[00:04:58]                 │   { key: 'space_1',
[00:04:58]                 │     doc_count: 7,
[00:04:58]                 │     countByType: 
[00:04:58]                 │      { doc_count_error_upper_bound: 0,
[00:04:58]                 │        sum_other_doc_count: 0,
[00:04:58]                 │        buckets: [Object] } } ] to sort of equal [ { key: 'default',
[00:04:58]                 │     doc_count: 9,
[00:04:58]                 │     countByType: 
[00:04:58]                 │      { doc_count_error_upper_bound: 0,
[00:04:58]                 │        sum_other_doc_count: 0,
[00:04:58]                 │        buckets: [Object] } },
[00:04:58]                 │   { doc_count: 7,
[00:04:58]                 │     key: 'space_1',
[00:04:58]                 │     countByType: 
[00:04:58]                 │      { doc_count_error_upper_bound: 0,
[00:04:58]                 │        sum_other_doc_count: 0,
[00:04:58]                 │        buckets: [Object] } } ]
[00:04:58]                 │       + expected - actual
[00:04:58]                 │ 
[00:04:58]                 │                  "key": "space"
[00:04:58]                 │                }
[00:04:58]                 │                {
[00:04:58]                 │                  "doc_count": 1
[00:04:58]                 │       +          "key": "config"
[00:04:58]                 │       +        }
[00:04:58]                 │       +        {
[00:04:58]                 │       +          "doc_count": 1
[00:04:58]                 │                  "key": "index-pattern"
[00:04:58]                 │                }
[00:04:58]                 │              ]
[00:04:58]                 │              "doc_count_error_upper_bound": 0
[00:04:58]                 │              "sum_other_doc_count": 0
[00:04:58]                 │            }
[00:04:58]                 │       -    "doc_count": 8
[00:04:58]                 │       +    "doc_count": 9
[00:04:58]                 │            "key": "default"
[00:04:58]                 │          }
[00:04:58]                 │          {
[00:04:58]                 │            "countByType": {
[00:04:58]                 │       
[00:04:58]                 │       at Assertion.assert (/dev/shm/workspace/parallel/13/kibana/packages/kbn-expect/expect.js:100:11)
[00:04:58]                 │       at Assertion.eql (/dev/shm/workspace/parallel/13/kibana/packages/kbn-expect/expect.js:244:8)
[00:04:58]                 │       at expectEmptyResult (test/spaces_api_integration/common/suites/delete.ts:133:24)
[00:04:58]                 │       at runMicrotasks (<anonymous>)
[00:04:58]                 │       at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:04:58]                 │ 
[00:04:58]                 │

Stack Trace

Error: expected [ { key: 'default',
    doc_count: 8,
    countByType: 
     { doc_count_error_upper_bound: 0,
       sum_other_doc_count: 0,
       buckets: [Object] } },
  { key: 'space_1',
    doc_count: 7,
    countByType: 
     { doc_count_error_upper_bound: 0,
       sum_other_doc_count: 0,
       buckets: [Object] } } ] to sort of equal [ { key: 'default',
    doc_count: 9,
    countByType: 
     { doc_count_error_upper_bound: 0,
       sum_other_doc_count: 0,
       buckets: [Object] } },
  { doc_count: 7,
    key: 'space_1',
    countByType: 
     { doc_count_error_upper_bound: 0,
       sum_other_doc_count: 0,
       buckets: [Object] } } ]
    at Assertion.assert (/dev/shm/workspace/parallel/13/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/13/kibana/packages/kbn-expect/expect.js:244:8)
    at expectEmptyResult (test/spaces_api_integration/common/suites/delete.ts:133:24)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5) {
  actual: '[\n' +
    '  {\n' +
    '    "countByType": {\n' +
    '      "buckets": [\n' +
    '        {\n' +
    '          "doc_count": 3\n' +
    '          "key": "visualization"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "dashboard"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "space"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "index-pattern"\n' +
    '        }\n' +
    '      ]\n' +
    '      "doc_count_error_upper_bound": 0\n' +
    '      "sum_other_doc_count": 0\n' +
    '    }\n' +
    '    "doc_count": 8\n' +
    '    "key": "default"\n' +
    '  }\n' +
    '  {\n' +
    '    "countByType": {\n' +
    '      "buckets": [\n' +
    '        {\n' +
    '          "doc_count": 3\n' +
    '          "key": "visualization"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "dashboard"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "config"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "index-pattern"\n' +
    '        }\n' +
    '      ]\n' +
    '      "doc_count_error_upper_bound": 0\n' +
    '      "sum_other_doc_count": 0\n' +
    '    }\n' +
    '    "doc_count": 7\n' +
    '    "key": "space_1"\n' +
    '  }\n' +
    ']',
  expected: '[\n' +
    '  {\n' +
    '    "countByType": {\n' +
    '      "buckets": [\n' +
    '        {\n' +
    '          "doc_count": 3\n' +
    '          "key": "visualization"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "dashboard"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "space"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "config"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "index-pattern"\n' +
    '        }\n' +
    '      ]\n' +
    '      "doc_count_error_upper_bound": 0\n' +
    '      "sum_other_doc_count": 0\n' +
    '    }\n' +
    '    "doc_count": 9\n' +
    '    "key": "default"\n' +
    '  }\n' +
    '  {\n' +
    '    "countByType": {\n' +
    '      "buckets": [\n' +
    '        {\n' +
    '          "doc_count": 3\n' +
    '          "key": "visualization"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "dashboard"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "config"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "index-pattern"\n' +
    '        }\n' +
    '      ]\n' +
    '      "doc_count_error_upper_bound": 0\n' +
    '      "sum_other_doc_count": 0\n' +
    '    }\n' +
    '    "doc_count": 7\n' +
    '    "key": "space_1"\n' +
    '  }\n' +
    ']',
  showDiff: true
}

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

legrego
legrego approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jportner jportner merged commit 171567d into elastic:master Mar 4, 2021
@kibanamachine kibanamachine mentioned this pull request Mar 4, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 4, 2021
@jportner @kibanamachine
ESLint rules for Spaces and Security (elastic#93644)
c6c5430
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #93711

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 5, 2021
@kibanamachine @jportner
ESLint rules for Spaces and Security (#93644) (#93711)
bf543d9 
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
@jportner jportner deleted the spaces-and-security-import-sorting branch January 19, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legrego legrego legrego approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jportner @kibanamachine @legrego