-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Fix iFrame Filtering Issues #95997
Conversation
Pinging @elastic/kibana-presentation (Team:Presentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and seems to work well!
Thank you @ThomThomson for the fix, the bug is critical and make the filters within embedded dashboard unused 👍 My I ask if you know when the fix will be published ? |
@yassine-ah, this fix will be released with 7.12.1, which we are targeting so far for April 20th. |
Is the 7.12.1 release date still planned for sometime today? Thanks. |
@ldefranco3434, unfortunately the release of 7.12.1 has been delayed. It's now looking to be closer to the end of April. Apologies for the delay. |
Is there anything we can implement in our deployment to fix these issues with the current version? |
On the edge of my seat 👀 |
@ThomThomson , thank you for the fix, I confirm that most of the issue with dashboard within iFrame were fixed but a problem still exist when using short URLs. When I compare between the url generated after sharing the dashboard without activating the short url, I get a I think this is the cause why I get the errors below: I am available if you want me to test something or provide you with more information, do you want me to create a separated issue ? Thanks |
Hi @yassine-ah, this seems like a separate problem, and would warrant another issue if you wouldn't mind creating one. I will try to recreate this problem. |
@ThomThomson Migrating to 7.14.0 I've discovered a problem that seems related to this issue. The different behavior of 7.14.0 can be see trying to navigate on shared IFrame link with some "query" criteria in url. Once the navigation is completed the "_a" section containing the "query" disappears from url (it mantains only the "_g" section). Exported Visualization, instead, works correctly on 7.14.0. We can update the "query" filter on url whenever we want because the "_a" section is mantained. Same behavior, after all, of shared dashboard links in previous releases. Actually we cannot update to 7.14.0 our solution for this problem |
Summary
This PR fixes an issue in the dashboard router where the embed settings object is recreated any time the URL changes. This was caused by #82909.
Fixing this issue addresses many issues with dashboard filtering in an iframe:
Fixes #94465
Fixes #94467
Fixes #91590
For maintainers