Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Data Frame Analytics results: ensure model evaluation stats are shown #97486

Merged

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Apr 19, 2021

Summary

Fixes #97322

This PR ensures that regression evaluation results handle NaN and Infinity values returned from _evaluate endpoint.
A unit test for getValuesFromResponse has been added as well.

Before:

image

After:

image

Checklist

Delete any items that are not applicable to this PR.

  • Unit or functional tests were updated or added to match the most common scenarios
  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.0MB 6.0MB +9.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87
Copy link
Contributor Author

This is ready for a look when you get a chance! 🙏 cc @qn895, @peteharverson, @darnautov

@qn895
Copy link
Member

qn895 commented Apr 19, 2021

LGTM

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could this also be backported for 7.12.2 ?

@alvarezmelissa87 alvarezmelissa87 merged commit ce2fec2 into elastic:master Apr 20, 2021
@alvarezmelissa87
Copy link
Contributor Author

Will be backported to 7.12.2 👍

alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Apr 20, 2021
…shown (elastic#97486)

* ensure we check for NaN and Infinity in eval response

* add unit test
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfa-regression-stats branch April 20, 2021 13:52
alvarezmelissa87 added a commit that referenced this pull request Apr 20, 2021
…shown (#97486) (#97642)

* ensure we check for NaN and Infinity in eval response

* add unit test
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request May 4, 2021
…shown (elastic#97486)

* ensure we check for NaN and Infinity in eval response

* add unit test
alvarezmelissa87 added a commit that referenced this pull request May 4, 2021
…shown (#97486) (#99256)

* ensure we check for NaN and Infinity in eval response

* add unit test
madirey pushed a commit to madirey/kibana that referenced this pull request May 11, 2021
…shown (elastic#97486)

* ensure we check for NaN and Infinity in eval response

* add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Data Frame Analytics Generalization Error Empty
5 participants