Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Updated documentation for Elastic Maps Server 7.13 #98310

Merged
merged 8 commits into from
Apr 28, 2021
Merged

[Maps] Updated documentation for Elastic Maps Server 7.13 #98310

merged 8 commits into from
Apr 28, 2021

Conversation

jsanz
Copy link
Member

@jsanz jsanz commented Apr 26, 2021

Summary

Adds to the documentation of hosted Elastic Maps Server the new basePath option and the new option to download basemaps for different zoom levels. Also a new screenshot for the initial state is included as the logic of basemaps changed the behaviour of the initial front-page.

Fixes #98172

@jsanz jsanz added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes docs v7.13.0 labels Apr 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

kmartastic
kmartastic reviewed Apr 26, 2021
View reviewed changes
Copy link
Contributor

@kmartastic kmartastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... a more detailed basemaps database, ...

I'm not sure if the word "basemaps" should be plural.

Basemaps database.
Basemap database.

I think it should be singular when I read the text.

What do you think @gchaps?

@nickpeihl
Copy link
Member

... a more detailed basemaps database, ...

I'm not sure if the word "basemaps" should be plural.

Basemaps database.
Basemap database.

I think it should be singular when I read the text.

What do you think @gchaps?

I think basemaps here refers to the style options in Kibana (Road map, Road map - desaturated, Dark map) so I'm OK with it being plural in that respect. All the basemap styles reference the same single database so database is singular.

nickpeihl
nickpeihl approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few nits, but otherwise lgtm!

docs/maps/connect-to-ems.asciidoc Outdated Show resolved Hide resolved
docs/maps/connect-to-ems.asciidoc Outdated Show resolved Hide resolved
docs/maps/connect-to-ems.asciidoc Outdated Show resolved Hide resolved
docs/maps/connect-to-ems.asciidoc Outdated Show resolved Hide resolved
@jsanz
Copy link
Member Author

jsanz commented Apr 26, 2021

just a few nits, but otherwise lgtm!

Thanks for the suggestions! Waiting for @gchaps in case you want to add anything else

gchaps
gchaps reviewed Apr 26, 2021
View reviewed changes
docs/maps/connect-to-ems.asciidoc
@@ -69,7 +67,7 @@ docker run --rm --init --publish 8080:8080 \
{ems-docker-image}
----------------------------------

Once {hosted-ems} is running, follow instructions from the webpage at `localhost:8080` to define a configuration file and download the basemaps database.
Once {hosted-ems} is running, follow instructions from the webpage at `localhost:8080` to define a configuration file and optionally download a more detailed basemaps database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this content in the preview of the doc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a conditional for this part to show up for released version builds, I don't know if there's a way to see this in a preview 😓

docs/maps/connect-to-ems.asciidoc Outdated Show resolved Hide resolved
docs/maps/connect-to-ems.asciidoc Outdated Show resolved Hide resolved
docs/maps/connect-to-ems.asciidoc Show resolved Hide resolved
jsanz and others added 8 commits April 27, 2021 15:16
@jsanz
Updated documentation for Elastic Maps Server 7.13
65aa2ec
@jsanz @nickpeihl
Update docs/maps/connect-to-ems.asciidoc
18999a8 
Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
@jsanz @nickpeihl
Update docs/maps/connect-to-ems.asciidoc
7d8453b 
Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
@jsanz @nickpeihl
Update docs/maps/connect-to-ems.asciidoc
216193c 
Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
@jsanz @nickpeihl
Update docs/maps/connect-to-ems.asciidoc
aa2e60a 
Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
@jsanz @gchaps
Update docs/maps/connect-to-ems.asciidoc
9d7f3c3 
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@jsanz @gchaps
Update docs/maps/connect-to-ems.asciidoc
14a6efe 
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@jsanz
Feedback, screenshot cropped to just the menu
9e7d93f
@jsanz jsanz force-pushed the ems-docs-basepath-download branch from 8589ca4 to 9e7d93f Compare April 27, 2021 13:18
@jsanz
Copy link
Member Author

jsanz commented Apr 27, 2021

@kmartastic anything else you'd like to change? You can see a preview of the new wording at this page

https://kibana_98310.docs-preview.app.elstc.co/guide/en/kibana/master/maps-connect-to-ems.html#elastic-maps-server-data

@kmartastic
Copy link
Contributor

@kmartastic anything else you'd like to change? You can see a preview of the new wording at this page

https://kibana_98310.docs-preview.app.elstc.co/guide/en/kibana/master/maps-connect-to-ems.html#elastic-maps-server-data

Looks great. Ship it.

@jsanz jsanz merged commit 66a1aff into elastic:master Apr 28, 2021
@jsanz jsanz deleted the ems-docs-basepath-download branch April 28, 2021 12:02
This was referenced Apr 28, 2021
Merged
Merged
jsanz added a commit to jsanz/kibana that referenced this pull request Apr 28, 2021
@jsanz @nickpeihl @gchaps
[Maps] Updated documentation for Elastic Maps Server 7.13 (elastic#98310
63371d3 
)

Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
jsanz added a commit that referenced this pull request Apr 28, 2021
@jsanz @nickpeihl @gchaps
[Maps] Updated documentation for Elastic Maps Server 7.13 (#98310) (#…
8ea42ee 
…98594)

Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
jsanz added a commit that referenced this pull request Apr 28, 2021
@jsanz @nickpeihl @gchaps
[Maps] Updated documentation for Elastic Maps Server 7.13 (#98310) (#…
a8a8dc8 
…98593)

Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
madirey pushed a commit to madirey/kibana that referenced this pull request May 11, 2021
@jsanz @nickpeihl
@gchaps @madirey
[Maps] Updated documentation for Elastic Maps Server 7.13 (elastic#98310
0425657 
)

Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps left review comments

@kmartastic kmartastic kmartastic left review comments

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation docs release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps][EMS] Update documentation to explain default and download options for Elastic Maps Server map data
5 participants
@jsanz @elasticmachine @nickpeihl @kmartastic @gchaps