Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] update es archive data to not include metrics data in functional test #98495

Merged
merged 3 commits into from
May 4, 2021
Merged

[Metrics UI] update es archive data to not include metrics data in functional test #98495

merged 3 commits into from
May 4, 2021

Conversation

neptunian
Copy link
Contributor

This is a follow up from #98177 Anomaly Flyout functional test. It removes the metric data that I was going to use to test the "show in inventory" link and view in a follow up PR, but since the data stream is not created properly by esArchiver at the moment, I won't be able to use this extra data. It causes the test to run slower having to load a 4+mb file so this makes it smaller/faster.

Once the archiver supports data streams, I'll recreate the data and add a test for the "show in inventory" link.

@neptunian neptunian added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Apr 27, 2021
@neptunian neptunian self-assigned this Apr 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@neptunian
Copy link
Contributor Author

@elasticmachine merge upstream

@neptunian
Copy link
Contributor Author

@elasticmachine merge upstream

estermv
estermv approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@estermv estermv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@neptunian neptunian merged commit 886295f into elastic:master May 4, 2021
neptunian added a commit to neptunian/kibana that referenced this pull request May 4, 2021
@neptunian @kibanamachine
update es archive data to not include metrics data (elastic#98495)
f15046a 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@neptunian neptunian mentioned this pull request May 4, 2021
Merged
neptunian added a commit that referenced this pull request May 4, 2021
@neptunian @kibanamachine
update es archive data to not include metrics data (#98495) (#99221)
0da1d6b 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estermv estermv estermv approved these changes

Assignees

@neptunian neptunian

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neptunian @elasticmachine @kibanamachine @estermv