-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting] Handling connectors with missing secrets during rule creation and action execution #98618
[Alerting] Handling connectors with missing secrets during rule creation and action execution #98618
Conversation
…ing/rules-with-imported-connectors
… on rule creation/update
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes LGTM! I have only question about the error message.
…ing/rules-with-imported-connectors
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @ymao1 |
…ion and action execution (elastic#98618) * [Connectors][API] Updated connectors with enabledAfterImport flag * fixed functional tests * added new field to connectors API docs * added update unit test * fixed test * renamed enableAfterImport to isMissingSecrets * removed onExport * revert the logic of true/false for isMissingSecrets * fixed test * fixed tests * added unit test * fixed docs * fixed import text and button labels * fixed import text * fixed text * Showing placeholder message when connector is missing secrets * Throwing error on isMissingSecrets = true before executing actions * Hiding connectors with missing secrets from dropdown * Checking for connectors with missing secrets during action validation on rule creation/update * Updating error wording Co-authored-by: Yuliia Naumenko <yuliia.naumenko@elastic.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…ion and action execution (#98618) (#99226) * [Connectors][API] Updated connectors with enabledAfterImport flag * fixed functional tests * added new field to connectors API docs * added update unit test * fixed test * renamed enableAfterImport to isMissingSecrets * removed onExport * revert the logic of true/false for isMissingSecrets * fixed test * fixed tests * added unit test * fixed docs * fixed import text and button labels * fixed import text * fixed text * Showing placeholder message when connector is missing secrets * Throwing error on isMissingSecrets = true before executing actions * Hiding connectors with missing secrets from dropdown * Checking for connectors with missing secrets during action validation on rule creation/update * Updating error wording Co-authored-by: Yuliia Naumenko <yuliia.naumenko@elastic.com> Co-authored-by: ymao1 <ying.mao@elastic.co> Co-authored-by: Yuliia Naumenko <yuliia.naumenko@elastic.com>
Resolves #94128
Summary
This PR does a few things to handle connectors where
isMissingSecrets: true
:isMissingSecrets: true
from the list of available connectors during rule creation. This means imported connectors that have not been fixed will not show up in the list of available connectors in theAlertAdd
flyout.isMissingSecrets
value for the connector used by each action. This should prevent actions with bad connectors from being added via the rule API.isMissingSecrets
value for connector used by the action and throws an error if it istrue
This shows up in the UI like:To verify
ndjson
file with the following:Checklist
Delete any items that are not applicable to this PR.