Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add missing subs #10990

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Docs: Add missing subs #10990

merged 1 commit into from
Jul 24, 2019

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jul 24, 2019

These are required for Asciidoctor and were already in every other
branch.

@nik9000
Docs: Add missing subs
581a2be 
These are required for Asciidoctor and were already in every other
branch.
@nik9000 nik9000 added the docs label Jul 24, 2019
@nik9000 nik9000 requested a review from karenzone July 24, 2019 17:27
@nik9000 nik9000 mentioned this pull request Jul 24, 2019
Merged
@nik9000
Copy link
Member Author

nik9000 commented Jul 24, 2019

It turns out that this is porting #10730 to a branch that I missed when I merged it.

karenzone
karenzone approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000 nik9000 merged commit 4af28ad into elastic:6.8 Jul 24, 2019
@nik9000
Copy link
Member Author

nik9000 commented Jul 24, 2019

Thanks for the review @karenzone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenzone karenzone karenzone approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nik9000 @karenzone