Revert "Add support for Kibana knowledge base entry assets (#807)" (#813

) This feature won't be likely released on this form. Reverting it by now. Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
elastic · Oct 10, 2024 · 3afde74 · 3afde74
1 parent dd05c30
commit 3afde74
Show file tree

Hide file tree

Showing 27 changed files with 1 addition and 435 deletions.
diff --git a/code/go/internal/validator/content.go b/code/go/internal/validator/content.go
@@ -25,7 +25,6 @@ func validateContentType(fsys fs.FS, path string, contentType spectypes.ContentT
 			}
 		}
 	case "application/json":
-	case "application/x-ndjson":
 	case "text/markdown":
 	case "text/plain":
 	default:

diff --git a/code/go/pkg/validator/validator_test.go b/code/go/pkg/validator/validator_test.go
@@ -44,7 +44,6 @@ func TestValidateFile(t *testing.T) {
 		"custom_ilm_policy":                  {},
 		"profiling_symbolizer":               {},
 		"logs_synthetic_mode":                {},
-		"knowledge_base":                     {},
 		"bad_additional_content": {
 			"bad-bad",
 			[]string{
@@ -228,13 +227,6 @@ func TestValidateFile(t *testing.T) {
 				`field data_stream.vars.data_stream.dataset: Does not match pattern '^[a-zA-Z0-9]+[a-zA-Z0-9\._]*$'`,
 			},
 		},
-		"bad_knowledge_base": {
-			"index_data/foo/manifest.yml",
-			[]string{
-				`field (root): index is required`,
-				`field (root): Additional property unknown is not allowed`,
-			},
-		},
 	}
 
 	for pkgName, test := range tests {

diff --git a/spec/changelog.yml b/spec/changelog.yml
@@ -7,9 +7,6 @@
     - description: Add support for content packages.
       type: enhancement
       link: https://github.com/elastic/package-spec/pull/777
-    - description: Add support for "Kibana knowledge base entry" assets.
-      type: enhancement
-      link: https://github.com/elastic/package-spec/pull/807
     - description: Add support for semantic_text field definition
       type: enhancement
       link: https://github.com/elastic/package-spec/pull/807

diff --git a/spec/content/index_data/manifest.spec.yml b/spec/content/index_data/manifest.spec.yml
diff --git a/spec/content/index_data/spec.yml b/spec/content/index_data/spec.yml
diff --git a/spec/content/spec.yml b/spec/content/spec.yml
@@ -46,11 +46,6 @@ spec:
     name: kibana
     required: false
     $ref: "./kibana/spec.yml"
-  - description: Folder containing Index data assets used by the package
-    type: folder
-    name: index_data
-    required: false
-    $ref: "./index_data/spec.yml"
   - description: Configuration file to process the results returned from the package validation. This file is just for package validation and it should be ignored when installing or using the package.
     type: file
     contentMediaType: "application/x-yaml"

diff --git a/spec/integration/kibana/spec.yml b/spec/integration/kibana/spec.yml
@@ -135,7 +135,7 @@ spec:
       contentMediaType: "application/json"
       pattern: '^{PACKAGE_NAME}-.+\.json$'
       forbiddenPatterns:
-        - '^.+-(ecs|ECS)\.json$' # ECS suffix is forbidden
+        - '^.+-(ecs|ECS)\.json$' # ECS suffix is forbidden 
 versions:
   - before: 3.3.0
     patch:

diff --git a/test/packages/bad_knowledge_base/LICENSE.txt b/test/packages/bad_knowledge_base/LICENSE.txt
diff --git a/test/packages/bad_knowledge_base/changelog.yml b/test/packages/bad_knowledge_base/changelog.yml
diff --git a/test/packages/bad_knowledge_base/docs/README.md b/test/packages/bad_knowledge_base/docs/README.md
diff --git a/test/packages/bad_knowledge_base/img/kibana-system.png b/test/packages/bad_knowledge_base/img/kibana-system.png
diff --git a/test/packages/bad_knowledge_base/img/system.svg b/test/packages/bad_knowledge_base/img/system.svg