Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Extends the list of tested versions #118

Merged
merged 5 commits into from
Jun 22, 2022

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Jun 9, 2022

This commit extends the list of tested versions. I started with the 7.11.x based on https://www.elastic.co/support/eol.

And removes the default media_type attribute in the Append processor to support 7.x Elasticsearch lower than 7.15.

@thbkrkr thbkrkr requested a review from olksdr as a code owner June 9, 2022 15:33
@olksdr
Copy link
Contributor

olksdr commented Jun 14, 2022

hey @thbkrkr,
please merge main in and let's see if the CI passes this time

@thbkrkr thbkrkr force-pushed the extend-list-of-tested-versions branch from 41a3ec8 to 3aec47e Compare June 14, 2022 12:04
@olksdr
Copy link
Contributor

olksdr commented Jun 14, 2022

looks like only issue there , that something which was not supported till 7.15


[2022-06-14T12:11:34.128Z] === RUN   TestAccDataSourceIngestProcessorPipeline

[2022-06-14T12:11:34.128Z]     processor_pipeline_data_source_test.go:11: Step 1/1 error: Error running apply: exit status 1

[2022-06-14T12:11:34.128Z]         

[2022-06-14T12:11:34.128Z]         Error: Unable to create or update ingest pipeline: pipeline_a

[2022-06-14T12:11:34.128Z]         

[2022-06-14T12:11:34.128Z]           with elasticstack_elasticsearch_ingest_pipeline.pipeline_a,

[2022-06-14T12:11:34.128Z]           on terraform_plugin_test.tf line 11, in resource "elasticstack_elasticsearch_ingest_pipeline" "pipeline_a":

[2022-06-14T12:11:34.128Z]           11: resource "elasticstack_elasticsearch_ingest_pipeline" "pipeline_a" {

[2022-06-14T12:11:34.128Z]         

[2022-06-14T12:11:34.128Z]         Failed with:

[2022-06-14T12:11:34.128Z]         {"error":{"root_cause":[{"type":"parse_exception","reason":"processor

[2022-06-14T12:11:34.128Z]         [append] doesn't support one or more provided configuration parameters

[2022-06-14T12:11:34.128Z]         [media_type]","processor_type":"append"}],"type":"parse_exception","reason":"processor

[2022-06-14T12:11:34.128Z]         [append] doesn't support one or more provided configuration parameters

[2022-06-14T12:11:34.128Z]         [media_type]","processor_type":"append"},"status":400}

[2022-06-14T12:11:34.128Z] --- FAIL: TestAccDataSourceIngestProcessorPipeline (1.64s)

@olksdr
Copy link
Contributor

olksdr commented Jun 14, 2022

The failing test might have to be updated to incorporate this difference and make it pass.

@thbkrkr
Copy link
Contributor Author

thbkrkr commented Jun 17, 2022

I'm not sure this is the best approach. Let me know if you had something different in mind.

Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, one more thing, could you, please, run make gen to re-generate the docs, since you added change to the description into the media_type field.

And also it might be a good idea to add the record to CHANGELOG file

@thbkrkr thbkrkr force-pushed the extend-list-of-tested-versions branch from b53c393 to 30a2851 Compare June 22, 2022 13:19
@thbkrkr thbkrkr force-pushed the extend-list-of-tested-versions branch from 30a2851 to c546336 Compare June 22, 2022 13:21
@olksdr olksdr merged commit cb74105 into elastic:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants