Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate elasticsearch connection #218

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Conversation

tobio
Copy link
Member

@tobio tobio commented Dec 6, 2022

Configuring provider connection configuration on a per-resource basis isn't supported during import operations, and duplicates the core Terraform aliases provider functionality.

Marking these attributes as deprecated as the first step to removing them in a future version of the provider.

Related to #203

@tobio tobio self-assigned this Dec 6, 2022
Copy link

@webfella webfella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Big 👍👍 for adding the guide for multiple deployments too mate!

@tobio tobio merged commit 351ba9e into main Dec 14, 2022
@tobio tobio deleted the deprecate-elasticsearch-connection branch December 14, 2022 03:04
@orlandothoeny
Copy link

This change makes it impossible to create a new ec_deployment instance + resources like an Elasticsearch User inside a single module without ugly workarounds

@orlandothoeny
Copy link

Got it to work using

provider "elasticstack" {
  elasticsearch {
    endpoints = [ec_deployment.deployment.elasticsearch.https_endpoint]
    username  = google_secret_manager_secret_version.root_user.secret_data
    password  = google_secret_manager_secret_version.root_password.secret_data
  }
}

However, had to manually remove the existing user resource from the state, always got an authentication error before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants