Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply zeroish values in SLM policies #224

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Apply zeroish values in SLM policies #224

merged 2 commits into from
Dec 14, 2022

Conversation

tobio
Copy link
Member

@tobio tobio commented Dec 14, 2022

Fixes #109

GetOk returns ok=false for zero valued attributes, so this option was never being set in the policy and the default (true) was applied.

@tobio tobio requested a review from webfella December 14, 2022 03:01
@tobio tobio self-assigned this Dec 14, 2022
@tobio tobio enabled auto-merge (squash) December 14, 2022 03:04
Copy link

@webfella webfella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobio tobio merged commit d63ebe1 into main Dec 14, 2022
@tobio tobio deleted the zeroish-slm-policies branch December 14, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] include_global_state parameter ignored for elasticstack_elasticsearch_snapshot_lifecycle
2 participants