Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kibana spaces #272

Merged
merged 4 commits into from
Feb 20, 2023
Merged

Kibana spaces #272

merged 4 commits into from
Feb 20, 2023

Conversation

tobio
Copy link
Member

@tobio tobio commented Feb 15, 2023

Fixes #5

@tobio tobio requested a review from webfella February 15, 2023 12:24
@tobio tobio self-assigned this Feb 15, 2023
webfella
webfella approved these changes Feb 19, 2023
View reviewed changes
Copy link

@webfella webfella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great mate! ⚡

internal/acctest/acctest.go
t.Fatal("KIBANA_ENDPOINT must be set for acceptance tests to run")
}

// Technically ES tests can use the API Key, however username/password is required for Kibana tests.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tobio tobio merged commit e662d3f into main Feb 20, 2023
@tobio tobio deleted the kibana-spaces branch February 20, 2023 02:42
@tobio tobio mentioned this pull request Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webfella webfella webfella approved these changes

Assignees

@tobio tobio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] support kibana spaces
2 participants
@tobio @webfella