Identify the missing/deleted resources in ES cluster #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionaly check response http status, and if it's 404 we know that
resource is missing and we must set ID to empty string ("") in the state
so the TF will be able to re-create the resources again.
TF will keep the state and resources up-to-date, even if those were
accidentally removed.
|
For review please see commit 69353a3, which has actual change. |
JoshMock
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For TF to understand that some resources were deleted manually (maybe by accident) we must make sure to set the resource id to empty string (""). In our case if ES reports back 404 we know that requested resource is missing and we can let TF restore it based on the configuration or update the TF state if the deletion was done appropriately.
As part of this PR I decided to split the ES client file into few different files by the cluster functionality.
fix: #37