Use go-elasticsearch v8 #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a few issues (#818, #793) where the provider is limited to the functionality provided by ES 7.x due to the usage of the v7 API client.
In reality, the only breaking change here is removing the ability to create indices with
include_type_nameset. Types have been entirely deprecated since 7.0 and limited to a single type per index since 6.0, usage ofinclude_type_nameshould already be minimal (or non-existent).We could of course maintain support for
include_type_nameby using a v7 client when accessing a v7 cluster. IMO the effort and complexity involved in doing so is nowhere near worthwhile at this point in the lifespan of ES types.